Update routines to call OneCovariance for tomography#298
Open
sachaguer wants to merge 13 commits into
Open
Conversation
cailmdaley
requested changes
Jul 24, 2026
cailmdaley
left a comment
Collaborator
There was a problem hiding this comment.
Nice and compact — the config plumbing does what it says. Two small initialization gaps will KeyError on first use; both are one-line fixes.
— Claude, on behalf of Cail
This was referenced Jul 24, 2026
Collaborator
|
oops sorry Sacha! i meant to review CosmoStat/shear_psf_leakage#35 instead of this PR, which i see may be in progress and which you hadn't requested my review on yet. |
Contributor
Author
|
The OneCovariance wrapper now runs in tomographic case (see figure below).
@cailmdaley this is ready for a review. A few things to note during the review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR should be quite small. OneCovariance already handles tomographic run. These commits are aimed at modifying the functions setting up the config file to compute a tomographic Cell covariance with OneCovariance.
In particular, it requires the computation of shape noise and galaxy density per tomographic bin.
This PR is related to the issue #283 .