fix(imsims): pin example sim configs to the rendered pixel scale 0.185#857
Merged
Conversation
The grid-sim images' delivered WCS carries exactly 0.185"/px, verified from image headers (see UNIONS-WL/MultiBand_ImSim#2). The example configs said 0.186/0.187. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017hsz3vrQT6t21fWSj1cxcj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delivered grid-sim images carry exactly 0.185 arcsec/px in their WCS. This is verified from the image headers.
The example configs said 0.186. One mask config said 0.187.
The value is nearly vestigial. ngmix builds its jacobian from the image WCS. The config value only sets the centroid-prior width and the noise window. So this is hygiene, not a science fix.
Closes UNIONS-WL/MultiBand_ImSim#2
— Fable, on behalf of Cail
🤖 Generated with Claude Code
https://claude.ai/code/session_017hsz3vrQT6t21fWSj1cxcj