Existing output directory#660
Draft
martinkilbinger wants to merge 21 commits intoCosmoStat:developfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main updates
The proposed changes in this PR allow the code to run when the output directory already exists. For this, the config entry
RUN_DATETIMEneeds to be set toFalse.Module runners can then check whether the output file to create already exists and skip computation.
As first cases this is done for mccd and ngmix.
In addition, regular expressions are allowed for the tile number IDs. This allows for a run of targeted input/output files instead of using all inputs.
This can be useful when a run is interrupted, in which case a re-run of the same module(s) will only be carried out for the still missing output files.
Some issues should be solved before merging, e.g. the log files will be overwritten.
Other changes:
Reviewer Checklist
developbranch