Open
Conversation
Member
|
Hey @tobias-liaudat, I recently merged a PR in PySAP that fixes the library issues for macOS. I have not tagged a new release yet as I need to tag a new release of Sparse2D first and there are a couple issues I need to investigate first. I am hoping to have this all resolved this week. I would propose that you tag new version of MCCD based on the new PySAP release for this PR before we merge. This should resolve most (if not all) the CI issues. |
Member
Author
|
Hi @sfarrens |
Member
|
One thing you could do now is make sure that MCCD works with the PySAP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor fix solves the bug generated by the new ModOpt version in MCCD.
Solves #601
Closes #601
Summary
Reviewer Checklist
developbranch