Skip to content

[BUG] [alpha] Journal calendar previous-month button has no tooltip #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whitebrendan wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

[BUG] [alpha] Journal calendar previous-month button has no tooltip #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/palette/CommandPalette.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ export function PaletteCommandPalette() {
const [selectedIndex, setSelectedIndex] = createSignal(0);
const [recentIds, setRecentIds] = createSignal<string[]>([]);
const [subMode, setSubMode] = createSignal<{ parentId: string; label: string; items: Array<{ id: string; label: string }> } | null>(null);
const [lastNavMode, setLastNavMode] = createSignal<"keyboard" | "mouse">("keyboard");
let inputRef: HTMLInputElement | undefined;
let listRef: HTMLDivElement | undefined;

Expand Down Expand Up @@ -151,8 +152,8 @@ export function PaletteCommandPalette() {

const handleKeyDown = (e: KeyboardEvent) => {
const list = flatList();
if (e.key === "ArrowDown") { e.preventDefault(); setSelectedIndex(i => Math.min(i + 1, list.length - 1)); }
else if (e.key === "ArrowUp") { e.preventDefault(); setSelectedIndex(i => Math.max(i - 1, 0)); }
if (e.key === "ArrowDown") { e.preventDefault(); setLastNavMode("keyboard"); setSelectedIndex(i => Math.min(i + 1, list.length - 1)); }
else if (e.key === "ArrowUp") { e.preventDefault(); setLastNavMode("keyboard"); setSelectedIndex(i => Math.max(i - 1, 0)); }
else if (e.key === "Enter") { e.preventDefault(); const c = list[selectedIndex()]; if (c) handleSelect(c.id); }
else if (e.key === "Escape") { e.preventDefault(); if (subMode()) exitSubMode(); else setShowCommandPalette(false); }
else if (e.key === "Backspace" && !query() && subMode()) { e.preventDefault(); exitSubMode(); }
Expand All @@ -173,7 +174,8 @@ export function PaletteCommandPalette() {
const sel = () => flatIdx() === selectedIndex();
return (
<div data-palette-item style={itemStyle(sel())} role="option" aria-selected={sel()}
onMouseEnter={() => setSelectedIndex(flatIdx())} onClick={() => handleSelect(cmd.id)}>
onMouseMove={() => setLastNavMode("mouse")}
onMouseEnter={() => { if (lastNavMode() === "mouse") setSelectedIndex(flatIdx()); }} onClick={() => handleSelect(cmd.id)}>
<Icon name="command" size={10} style={{ color: "var(--jb-text-muted-color)", "flex-shrink": "0" }} />
<Show when={!subMode()}>
<span style={{ "font-size": "10px", color: "var(--jb-text-muted-color)", "white-space": "nowrap" }}>{cmd.category || "General"}</span>
Expand Down