Recognize whitespace after dollar signs in price watches

[charan-rathore]

What changed

A price_below watch recognizes $9.99 and USD 9.99 but silently misses $ 9.99, even though that amount is below its threshold. Page text can separate the currency sign and amount with spaces, tabs, line breaks or nonbreaking spaces.

Allow whitespace after either of the already-supported dollar labels. Add eight public-workflow regressions that verify saved match state and notifications, including above-threshold and equal-threshold controls. No new currency or comparison behavior is added.

This is self-discovered; no issue or prior maintainer discussion is claimed. Open PR #16 adds price_above but retains this parser behavior. A rebase may be needed if it lands first. Open #66 and #83 also edit apps/server/src/engine/service.ts, in other parts of the monitor code.

Verification

• Exact unpatched base: four new tests fail, four pass. A minimal public createMonitor/worker.tick reproduction misses the notification.
• Patched full suite on Node 24.21.0: 284 passed, zero failures.
• Repository Biome lint, root/mobile/worker type checks and server build pass.
• One-command verification was executed successfully: baseline reproduction fails, patched full suite and checks pass, and fresh web/iOS/Android exports pass.

Integration limits

Tests use a real local HTTP worker fixture, disposable store and synthetic product page. No live website, provider key or personal data was used. Fresh-worktree web/iOS/Android exports pass. Earlier development-worktree attempts failed dependency resolution through reused node_modules symlinks; a fresh frozen install resolved that setup problem. No native device, Chromium lifecycle or Docker checks are claimed. This is server-side interpretation of an existing browser observation.

[jerelvelarde]

Useful bounded price-watch parsing fix: whitespace after the existing dollar labels now matches without changing the threshold comparison. All eight public workflow regressions pass locally, including equal/above-threshold controls and persisted notifications. Description covers verification and fixture/platform limits. No actionable correctness or security findings; merge after all required checks pass.

[jerelvelarde]

Re-reviewed after the current-main update. The production patch and regression scope remain unchanged, and merged calendar/Gmail/resource security and controlled browser fixture changes are retained. No new actionable findings. Approval applies to this updated head; merge once all seven required CI checks pass.

[charan-rathore]

Thanks for the quick re-review. One snag on CI: four of the seven jobs on the current head (browser-container, computer-container, platform android, platform web) were cancelled about twenty minutes in, with no failing step recorded, so the run ended without them finishing. The other three passed. Could you re-run the workflow when you get a chance? Happy to push a no-op if that is easier.

[jerelvelarde]

Rechecked current-main integration: only the intended spaced-dollar parsing and regression remain. Eight public price-watch workflow tests pass, preserving threshold comparison and durable notifications. Useful bounded fix, clear verification/limits, no remaining correctness/security blocker. All seven required CI checks are green.