-
Notifications
You must be signed in to change notification settings - Fork 492
fix: let long page titles wrap in the page editor #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charan-rathore
wants to merge
1
commit into
CopilotKit:main
Choose a base branch
from
charan-rathore:fix-long-page-title-clipped-68
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−8
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { useLayoutEffect, useRef } from 'react'; | ||
|
|
||
| export function singleLineTitle(value: string): string { | ||
| return value.replace(/[\r\n]+/g, ' '); | ||
| } | ||
|
|
||
| export function PageTitleField({ | ||
| value, | ||
| onChange, | ||
| }: { | ||
| value: string; | ||
| onChange: (title: string) => void; | ||
| }) { | ||
| const ref = useRef<HTMLTextAreaElement>(null); | ||
| useLayoutEffect(() => { | ||
| const el = ref.current; | ||
| if (!el) return; | ||
| el.style.height = 'auto'; | ||
| el.style.height = `${el.scrollHeight}px`; | ||
| }, [value]); | ||
| return ( | ||
| <textarea | ||
| ref={ref} | ||
| className="document-title" | ||
| aria-label="Page title" | ||
| placeholder="Untitled page" | ||
| maxLength={160} | ||
| rows={1} | ||
| value={value} | ||
| onChange={(event) => onChange(singleLineTitle(event.target.value))} | ||
| onKeyDown={(event) => { | ||
| if (event.key === 'Enter') event.preventDefault(); | ||
| }} | ||
| /> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { renderToStaticMarkup } from 'react-dom/server'; | ||
| import { expect, it } from 'vitest'; | ||
| import { | ||
| PageTitleField, | ||
| singleLineTitle, | ||
| } from '../src/client/editor/PageTitleField'; | ||
|
|
||
| it('renders the page title as a wrapping textarea so long titles are not clipped', () => { | ||
| const html = renderToStaticMarkup( | ||
| <PageTitleField | ||
| value="AI Coworkers: OpenAI Dots vs Meta Muse vs OpenDots" | ||
| onChange={() => {}} | ||
| />, | ||
| ); | ||
| expect(html).toContain('<textarea'); | ||
| expect(html).toContain('aria-label="Page title"'); | ||
| expect(html).toContain('rows="1"'); | ||
| expect(html).toContain('maxLength="160"'); | ||
| expect(html).toContain('AI Coworkers: OpenAI Dots vs Meta Muse vs OpenDots'); | ||
| }); | ||
|
|
||
| it('keeps the title on a single logical line when text with line breaks is pasted', () => { | ||
| expect(singleLineTitle('First\nSecond\r\nThird')).toBe('First Second Third'); | ||
| expect(singleLineTitle('Plain title')).toBe('Plain title'); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Recalculate title height when available width changes. This effect depends only on value. Resizing the actual field from 1440px to 375px leaves clientHeight at 208px while scrollHeight grows to 250px; overflow:hidden clips the last line until the user edits the title. Recalculate on element width changes, covering viewport and panel resizing, and add a browser regression for this case.