fix: clear the connection error once polling recovers - #73
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
A successful workspace or capture poll now clears only the connection notice, so a recovered server no longer leaves the error banner up. Errors from user actions are kept apart and still need a dismiss. Fixes CopilotKit#51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
After the API restarted, the red connection banner stayed up because nothing cleared it on a later successful poll.
Connection notices (failed fetch, 502/504, unreadable response) are now tracked separately from action errors. A successful workspace or capture poll clears only the connection notice. Action errors still need a dismiss, and 401 handling is unchanged. The logic is in
src/client/poll-notice.tswith unit tests.Checked locally on current main (c2569bb):
npx vitest run(36 files, 168 tests),tsc --noEmit, eslint and prettier all pass. The tests cover the notice logic only. I did not exercise the banner in a browser against a restarted API, and did not runnpm run build.