Repository navigation
CI: one runner wait for the PR upgrade check, model lock on the 16-core pool - #1921
Merged
Merged
Conversation
…re pool Desktop upgrade on a pull request waited for two runners in a row: a small job on the shared standard pool to name the previous release, then the upgrade job. Both queued (3 to 6 and 9 to 16 minutes) around about 3.5 minutes of work. The upgrade job now finds the previous release itself, and the separate legs job runs only for the nightly window. Model lock started one job per harness on the standard pool, which the organisation caps at 60 concurrent jobs; a lock change queued 8 to 13 minutes per job and took 32 minutes for at most 7.5 of work. Both of its jobs now run on the 16-core pool. Desktop macOS signing cancels a pull request's superseded dry run, so a stale run does not hold one of the few macOS runners. Tag, main and dispatch runs, the ones that sign, still never cancel.
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 20, 2026 05:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Faster pull request runs for Desktop upgrade, Model lock and Desktop macOS signing. All three were mostly waiting for runners, not working.
Changes
upgrade-legs.ts previouscall), so the run waits for one runner instead of two in a row. Thelegsjob runs only for the nightly and on-demand window, now on the 16-core pool. Nothing else about the test changes; with no earlier release the job does nothing, as before.pull_requestevent, so cancelling its runs would change signing behaviour.Checks
signing-workflows,signed-build,staple-with-retry,desktop-updates,release-latest,release-publish-order,model-compat-langgraph-ts.