Repository navigation
Pin the LangGraph harness on release/1.1 to the set it was proven with - #1842
Open
jerelvelarde wants to merge 2 commits into
Open
jerelvelarde wants to merge 2 commits into
jerelvelarde wants to merge 2 commits into
Conversation
agent-langgraph-agui's requirements were unpinned, and today's resolve took langchain-anthropic 1.7.11, which sends anthropic-version 2023-06-01 instead of the SDK default 2026-10-21. "python harness regressions" went red on a PR that never touched the harness. The model clients are now pinned to the set the model lock verified and main last passed on: langchain-anthropic 1.7.10, anthropic 2.10.0, langchain-core 1.8.2, langchain-openai 1.8.1, langgraph 1.2.22 and langchain-google-genai 4.4.3. The Dockerfile installs the same file, so CI and the image agree. requirements-test.txt no longer overrides langchain-openai to 1.6.0, so CI tests what the image ships. The provider boundary test no longer requires the SDK's default version. Anthropic serves both 2023-06-01 and 2026-10-21, and 2026-10-21 only adds refusals for temperature, top_p and top_k (plus two content-block cases). The test now checks that the request carries a version Anthropic serves and that the body has no sampling parameters. A live request on each version answered from Claude Opus 5.5, Sonnet 5.5, Haiku 5.5 and Fable 5.2. Tested: the unpinned resolve fails 5 tests on the old assertion; the pinned set passes all 188, and the new assertion passes on both resolves. The model lock workflow rebuilt the harness image and passed. (cherry picked from commit 0f69809)
The comment carried over from CopilotKit#1826 cites shared/model-lock.json and the "Model lock" section of docs/releasing.md. Both arrived on main with the model check, which release/1.1 does not have, so on this branch the comment pointed at nothing. It now names the pinned set by where it was proven.
jerelvelarde
requested review from
MikeRyanDev,
davidmckayv,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 18, 2026 21:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Every pull request into
release/1.1fails "python harness regressions" today, whatever it touches, and the aggregate "verify" check fails with it. The LangGraph harness on this branch installs its model clients unpinned, so each CI run resolves whatever LangChain released that morning. langchain-anthropic 1.7.11 came out on 2026-11-18 and sendsanthropic-version: 2023-06-01, where the Anthropic SDK defaults to2026-10-21. The provider boundary test asserts the SDK default, so five of its cases now fail on a branch nobody changed.mainfixed this in #1826. That fix never reachedrelease/1.1, and 1.1 is the line that ships, so a PR that has to land on OpenBot 1.1 (for example #1837) cannot go green until the release branch has it too.The approach
This backports #1826 as a cherry-pick. It applied cleanly, and the commit keeps its original author and message. It does three things.
Pins the model clients in
agent-langgraph-agui/requirements.txtto the set main last passed on: langgraph 1.2.22, langchain-core 1.8.2, langchain-openai 1.8.1, langchain-anthropic 1.7.10, anthropic 2.10.0 and langchain-google-genai 4.4.3. The harness Dockerfile installs the same file, so CI and the image stay on the same versions.Drops the
langchain-openai==1.6.0override fromrequirements-test.txt, so the tests run against the client the image ships, not an older one.Loosens the provider boundary assertion from "the SDK's default version" to "a version Anthropic serves" (
2023-06-01or2026-10-21), and adds the check that matters for2026-10-21: the request body carries notemperature,top_portop_k. The pin alone would fix today's failure. The looser assertion stops the next langchain-anthropic release that picks a different, still-served version from breaking the branch again.A second commit changes one comment. The pin's comment on main cites
shared/model-lock.jsonand the "Model lock" section ofdocs/releasing.md. Both came to main with the model check (#1779), whichrelease/1.1does not have, so on this branch the comment pointed at files that do not exist. It now says where the set was proven and that it moves as one set. Nothing else differs from #1826.The cost: the harness on 1.1 no longer picks up client fixes on its own. Moving these versions is now a deliberate change, the same as on main.
What is not covered
release/1.1the pinned set has not been tested against live models. It is the set main proved. The tests here check what the harness sends, not live replies.Verification
requirements.txtandrequirements-test.txtexactly as the CI step does:python -m pytest agent-langgraph-agui/tests -qgave171 passed, with langchain-anthropic 1.7.10, anthropic 2.10.0, langchain-core 1.8.2 and langgraph 1.2.22 installed. The LangGraph step in CI runs this same command.release/1.1, the same step reports5 failed, 166 passed, all five intest_anthropic_selection_reaches_anthropic_boundary_without_openai_keyonassert '2023-06-01' == '2026-10-21'.Merge notes
Once this merges, #1837 and any other open PR into
release/1.1needs to merge or rebase on the new branch tip to pick up the fix. If #1779 is later backported to 1.1, put the comment inrequirements.txtback to main's wording so it cites the model lock again.