Repository navigation
Model check: read the LangGraph (TypeScript) engine's Gemini client, and test the lock rule on its own lock - #1793
Merged
davidmckayv merged 1 commit intoNov 17, 2026
Conversation
…and test the lock rule on its own lock The engine ships @langchain/google, which the probe did not read, so a run recorded no Gemini client for it. Two tests read the live model lock and could only pass while it was empty, so the first lock refresh after a real run would have failed them; they now build on an unrun lock of their own.
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 17, 2026 23:28
davidmckayv
merged commit Nov 17, 2026
32d7855
into
feat/model-lock-langgraph-ts
14 of 15 checks passed
davidmckayv
added a commit
that referenced
this pull request
Nov 17, 2026
…and test the lock rule on its own lock (#1793) The engine ships @langchain/google, which the probe did not read, so a run recorded no Gemini client for it. Two tests read the live model lock and could only pass while it was empty, so the first lock refresh after a real run would have failed them; they now build on an unrun lock of their own.
davidmckayv
added a commit
that referenced
this pull request
Nov 18, 2026
…and test the lock rule on its own lock (#1793) The engine ships @langchain/google, which the probe did not read, so a run recorded no Gemini client for it. Two tests read the live model lock and could only pass while it was empty, so the first lock refresh after a real run would have failed them; they now build on an unrun lock of their own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to #1778, found by its first real run against the LangGraph (TypeScript) engine.
What
package.jsonnames@langchain/google, but the probe'sNODE_CLIENTSlisted only@langchain/google-genai, so a run recorded no Gemini client version for the engine.@langchain/googleis added (@langchain/google-genaistays, for any image that ships it).MODEL_LOCK, so they could pass only while the engine's entry was empty. The first lock refresh after a real run would have failed them. Both now build on an unrun lock defined in the test.Tests
@langchain/googletoo. Red before the change (the probe returned every client except it), green after.shared/model-lock.json, all 8 tests inscripts/model-compat-langgraph-ts.test.tspass; before this change two failed. With the committed empty lock: 8 pass.The run that found them
--tags sourceon the engine atfeat/langgraph-ts, and again on the image the internal build published from the same commit, with the same result on every row: Anthropic 15 of 15, OpenAI 29 of 29, Google 20 of 24. The four Google refusals are the provider's:gemini-2.5-flash-liteis closed to new users,gemini-decision-1is not a chat model, andgemini-omni-1.1-flashandgemini-omni-1.2-flashonly take Google's Interactions API.