Skip to content

Fix audio annunciator being unable to use audio files which have a space in their path #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LordIdra wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Fix audio annunciator being unable to use audio files which have a space in their path #3993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ator/src/main/java/org/phoebus/applications/alarm/audio/annunciator/AudioAnnunciator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ public AudioAnnunciator() {
* @param url URL of the audio file
* @return MediaPlayer
*/
private MediaPlayer createMediaPlayer(String url) {
private MediaPlayer createMediaPlayer(final String rawUrl) {
// MediaPlayer does not accept URLs with spaces; see https://github.com/ControlSystemStudio/phoebus/issues/3992
final String url = rawUrl.replace(" ", "%20");

try {
MediaPlayer player = new MediaPlayer(new Media(url));
if (player.getError() == null) {
Expand Down
Loading