[LordIdra]

See #3960

Please let me know if this should be implemented differently e.g. only if the file does not exist rather than for any error

Checklist

• Testing:

  • The feature has automated tests
  • Tests were run
  • Tested manually that application starts as normal and logs an error when -settings file does not exist, and that the settings are loaded if the -settings file does exist

• Documentation:

  • The feature is documented
  • The documentation is up to date (could not find any docs to update)
  • Release notes:
    • Added an entry if the change is breaking or significant
    • Added an entry when adding a new feature

[georgweiss]

@LordIdra, this change would unfortunately break the launch procedure for several sites. Following a discussion in the Codathon, we'd like to propose a new application argument (e.g. force_start) to control the behavior. This argument should default to false (i.e. of not specified on the command line), but if true, Phoebus would start in the manner proposed in this PR.

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[LordIdra]

@LordIdra, this change would unfortunately break the launch procedure for several sites. Following a discussion in the Codathon, we'd like to propose a new application argument (e.g. force_start) to control the behavior. This argument should default to false (i.e. of not specified on the command line), but if true, Phoebus would start in the manner proposed in this PR.

Ok, yes I was wondering if this might be too specific too our site. I have added the flag (could not think of a better name than force_start) and addressed the SonarCloud lint.

Do any of the remaining lints need to be addressed? I have more or less kept the code uniform with the rest of the file, so they do not seem to be relevant