Change how AlarmTableUI handles selecting items when state changes to no longer clear manually selected items#3700
Open
Peyton-Hill-CLS wants to merge 4 commits intoControlSystemStudio:masterfrom
Conversation
Member
|
similar to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, whenever the alarm table state changes or when the user searches for something, any selected rows get cleared and it creates a new selection based of the search input. If there is no search input, then all selections are cleared. This means that any items selected with a users mouse get cleared when an alarm is added, removed, or is modified (such as the pv severity changing). This can cause user frustration, particularly when a pv severity is flickering in and out of different states.
This PR attempts to fix this by recording all the pv's that were previously selected that are still in the new alarm list when the state changes. After the rows are updated with the new alarms, create a new selection with this pv list.