Skip to content

Fix hardcoded java dockerfile by using wildcard in copy source path#321

Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom
GREENRAT-K405:fix/hardcoded-java-dockerfile
Feb 14, 2026
Merged

Fix hardcoded java dockerfile by using wildcard in copy source path#321
pradeeban merged 1 commit intoControlCore-Project:devfrom
GREENRAT-K405:fix/hardcoded-java-dockerfile

Conversation

@GREENRAT-K405
Copy link

@GREENRAT-K405 GREENRAT-K405 commented Feb 14, 2026

Changed the hardcoded 0.0.1-SNAPSHOT.jar with *(wildcard)

This will make sure the maintainers don't have to manually change version in dockerfile every time the concore gets an version update. This fixes #320

@GREENRAT-K405 GREENRAT-K405 changed the base branch from main to dev February 14, 2026 17:52
@GREENRAT-K405
Copy link
Author

@pradeeban please have a look.

@GREENRAT-K405
Copy link
Author

@pradeeban this dockerfile also lacks build stage.
We could setup the ./target/ manually but if someone wants to simply just clone the repo and get started... it lacks the build stage.

Should I work on this?

@pradeeban pradeeban merged commit bee46ba into ControlCore-Project:dev Feb 14, 2026
6 checks passed
@pradeeban
Copy link
Member

Sure, Go ahead.
concore doesn't have a Java implementation. Any code you see should be considered a toy. That is why all the obvious bugs you all are spotting in the Java implementation.

@GREENRAT-K405
Copy link
Author

Understood! I will at least create a minimal fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The java dockerfile is hardcoded to use an outdated version

2 participants