Skip to content

fix: replace concore2 imports with concore (resolves #287)#306

Merged
pradeeban merged 26 commits intoControlCore-Project:devfrom
GaneshPatil7517:fix/replace-concore2-imports
Feb 14, 2026
Merged

fix: replace concore2 imports with concore (resolves #287)#306
pradeeban merged 26 commits intoControlCore-Project:devfrom
GaneshPatil7517:fix/replace-concore2-imports

Conversation

@GaneshPatil7517
Copy link

@GaneshPatil7517 GaneshPatil7517 commented Feb 14, 2026

@pradeeban

Summary

This PR resolves Issue #287 by replacing all references to the non-existent concore2 module with concore.

The repository does not contain a concore2.py module, and it is neither listed in requirements.txt nor generated by mkconcore.py. As a result, scripts importing concore2 fail with ModuleNotFoundError.

Based on maintainer feedback, concore2 appears to be a legacy name used for the second edition of concore. Therefore, this PR standardizes all imports to use concore.

Changes Made

  • Replaced import concore2 with import concore (and removed duplicate imports where import concore already existed)
  • Updated all concore2. references to concore. across 20 files:
    • concore2.delay concore.delay
    • concore2.inpath concore.inpath
    • concore2.outpath concore.outpath
    • concore2.simtime concore.simtime
    • concore2.read() concore.read()
    • concore2.write() concore.write()
    • concore2.unchanged() concore.unchanged()
    • concore2.initval() concore.initval()

Affected Files

  • 0mq/comm_node.py
  • 0mq/funbody.py, 0mq/funbody2.py
  • 0mq/funbody_distributed.py, 0mq/funbody_zmq.py, 0mq/funbody_zmq2.py
  • 0mq/funcall.py, 0mq/funcall2.py
  • 0mq/funcall_distributed.py, 0mq/funcall_zmq.py, 0mq/funcall_zmq2.py
  • measurements/comm_node_test.py
  • measurements/Latency/funbody_distributed.py, measurements/Latency/funcall_distributed.py
  • nintan/powermetermax.py
  • ratc/learn3.py
  • testsou/funbody.py, testsou/funcall.py, testsou/mix.py, testsou/powermetermax.py

Scope Control

  • No changes were made to:
    • concore-lite repository
    • Verilog implementation
    • Any unrelated modules

Testing

  • Verified no remaining concore2 references exist in any Python file.
  • Confirmed scripts no longer raise ModuleNotFoundError due to missing module.

This PR is limited strictly to import correction and does not alter logic or behavior.

image

Copilot AI review requested due to automatic review settings February 14, 2026 05:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Issue #287 by replacing imports of the non-existent concore2 module with concore across 20 Python files. The concore2 module was a legacy name that never existed in the repository, causing ModuleNotFoundError when these scripts were executed.

Changes:

  • Removed import concore2 statements and replaced all concore2. references with concore. across all affected files
  • Updated simulation time tracking, port configurations, and I/O operations to use the single concore module
  • Modified initialization patterns where both concore and concore2 were previously configured with the same values

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 50 comments.

Show a summary per file
File Description
testsou/powermetermax.py Replaced concore2 with concore for dual-channel power meter communication
testsou/mix.py Updated mixer node to use single concore instance for multi-input handling
testsou/funcall.py Converted function caller to use unified concore for request-response pattern
testsou/funbody.py Updated function body to use single concore for bidirectional communication
ratc/learn3.py Modified learning algorithm to use unified concore for data collection
nintan/powermetermax.py Replaced concore2 with concore for power measurement communication
measurements/comm_node_test.py Updated communication node test to use single concore instance
measurements/Latency/funcall_distributed.py Modified distributed function caller for latency measurement
measurements/Latency/funbody_distributed.py Updated distributed function body for latency testing
0mq/funcall_zmq2.py Converted ZMQ-based function caller to use unified concore
0mq/funcall_zmq.py Updated ZMQ function caller with single concore instance
0mq/funcall_distributed.py Modified distributed ZMQ function caller
0mq/funcall2.py Updated 0MQ function caller variant
0mq/funcall.py Converted 0MQ function caller to use single concore
0mq/funbody_zmq2.py Updated ZMQ function body variant
0mq/funbody_zmq.py Modified ZMQ-based function body
0mq/funbody_distributed.py Updated distributed function body
0mq/funbody2.py Converted 0MQ function body variant
0mq/funbody.py Updated 0MQ function body to use unified concore
0mq/comm_node.py Modified communication node for single concore instance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GaneshPatil7517 and others added 25 commits February 14, 2026 11:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Remove duplicate concore.delay assignments (12 files)
- Remove self-assignment no-ops: concore.inpath/outpath = concore.inpath/outpath (9 files)
- Use float(concore.simtime) snapshot for old2/old_concore_simtime variables (7 files)
@pradeeban pradeeban merged commit 098f4a5 into ControlCore-Project:dev Feb 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants