fix: replace concore2 imports with concore (resolves #287)#306
Merged
pradeeban merged 26 commits intoControlCore-Project:devfrom Feb 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #287 by replacing imports of the non-existent concore2 module with concore across 20 Python files. The concore2 module was a legacy name that never existed in the repository, causing ModuleNotFoundError when these scripts were executed.
Changes:
- Removed
import concore2statements and replaced allconcore2.references withconcore.across all affected files - Updated simulation time tracking, port configurations, and I/O operations to use the single
concoremodule - Modified initialization patterns where both
concoreandconcore2were previously configured with the same values
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 50 comments.
Show a summary per file
| File | Description |
|---|---|
| testsou/powermetermax.py | Replaced concore2 with concore for dual-channel power meter communication |
| testsou/mix.py | Updated mixer node to use single concore instance for multi-input handling |
| testsou/funcall.py | Converted function caller to use unified concore for request-response pattern |
| testsou/funbody.py | Updated function body to use single concore for bidirectional communication |
| ratc/learn3.py | Modified learning algorithm to use unified concore for data collection |
| nintan/powermetermax.py | Replaced concore2 with concore for power measurement communication |
| measurements/comm_node_test.py | Updated communication node test to use single concore instance |
| measurements/Latency/funcall_distributed.py | Modified distributed function caller for latency measurement |
| measurements/Latency/funbody_distributed.py | Updated distributed function body for latency testing |
| 0mq/funcall_zmq2.py | Converted ZMQ-based function caller to use unified concore |
| 0mq/funcall_zmq.py | Updated ZMQ function caller with single concore instance |
| 0mq/funcall_distributed.py | Modified distributed ZMQ function caller |
| 0mq/funcall2.py | Updated 0MQ function caller variant |
| 0mq/funcall.py | Converted 0MQ function caller to use single concore |
| 0mq/funbody_zmq2.py | Updated ZMQ function body variant |
| 0mq/funbody_zmq.py | Modified ZMQ-based function body |
| 0mq/funbody_distributed.py | Updated distributed function body |
| 0mq/funbody2.py | Converted 0MQ function body variant |
| 0mq/funbody.py | Updated 0MQ function body to use unified concore |
| 0mq/comm_node.py | Modified communication node for single concore instance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Remove duplicate concore.delay assignments (12 files) - Remove self-assignment no-ops: concore.inpath/outpath = concore.inpath/outpath (9 files) - Use float(concore.simtime) snapshot for old2/old_concore_simtime variables (7 files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pradeeban
Summary
This PR resolves Issue #287 by replacing all references to the non-existent
concore2module withconcore.The repository does not contain a
concore2.pymodule, and it is neither listed inrequirements.txtnor generated bymkconcore.py. As a result, scripts importingconcore2fail withModuleNotFoundError.Based on maintainer feedback,
concore2appears to be a legacy name used for the second edition of concore. Therefore, this PR standardizes all imports to useconcore.Changes Made
import concore2withimport concore(and removed duplicate imports whereimport concorealready existed)concore2.references toconcore.across 20 files:concore2.delayconcore.delayconcore2.inpathconcore.inpathconcore2.outpathconcore.outpathconcore2.simtimeconcore.simtimeconcore2.read()concore.read()concore2.write()concore.write()concore2.unchanged()concore.unchanged()concore2.initval()concore.initval()Affected Files
0mq/comm_node.py0mq/funbody.py,0mq/funbody2.py0mq/funbody_distributed.py,0mq/funbody_zmq.py,0mq/funbody_zmq2.py0mq/funcall.py,0mq/funcall2.py0mq/funcall_distributed.py,0mq/funcall_zmq.py,0mq/funcall_zmq2.pymeasurements/comm_node_test.pymeasurements/Latency/funbody_distributed.py,measurements/Latency/funcall_distributed.pynintan/powermetermax.pyratc/learn3.pytestsou/funbody.py,testsou/funcall.py,testsou/mix.py,testsou/powermetermax.pyScope Control
Testing
concore2references exist in any Python file.ModuleNotFoundErrordue to missing module.This PR is limited strictly to import correction and does not alter logic or behavior.