use context managers for file I/O#301
Merged
pradeeban merged 2 commits intoControlCore-Project:devfrom Feb 14, 2026
Merged
Conversation
avinxshKD
force-pushed
the
refactor-file-io-v2
branch
from
c3fe122 to
f67c7d3
Compare
This was referenced Feb 13, 2026
Merged
Member
|
@avinxshKD can you pls resolve the conflicts. |
Author
yes, on it |
avinxshKD
force-pushed
the
refactor-file-io-v2
branch
2 times, most recently
from
c539ee4 to
e653cd8
Compare
Author
|
@pradeeban hey hve rebased on upstream/dev. Dropped the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #298
Wrapped all open() calls with context managers in cwrap.py, testsou/concore.py, and testsou/ccpymat.dir/concore.py. This ensures files are properly closed even if an exception occurs, preventing descriptor leaks especially in loops where files are opened repeatedly.