Upgrade scssphp to 1.13.0, fix PHP 8.4 deprecations#274
Open
Upgrade scssphp to 1.13.0, fix PHP 8.4 deprecations#274
Conversation
Replaces the embedded scssphp library with the latest 1.x release (v1.13.0, Aug 2023), which is the highest version before the breaking 2.0.0 rewrite. Also applies explicit nullable type fixes (Type $x = null → ?Type $x = null) to suppress PHP 8.4 deprecation notices.
The merge commit d83318a silently re-added 188 files from scssphp 1.11.0's experimental new architecture (Ast/, Serializer/, Parser/, Value/, Visitor/, etc.) that were removed in 1.13.0. These files don't exist in the upstream 1.13.0 release and are dead code — the autoloader never requests them — but they bloat the bundle and misrepresent the library version. Restores scssphp/src/ to exactly the 1.13.0 file set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?Typenullable parameter fixes throughout the library to suppress PHP 8.4 deprecation noticesWhat changed in scssphp 1.13.0
Ast/,Serializer/,Parser/,Value/,Visitor/new-architecture files that were bundled in 1.11 but unusedFormatter/Compact,Formatter/Nested,Formatter/Crunched,Formatter/DebugclassesPHP 8.4 deprecations fixed
All parameters typed as
Type $x = nullchanged to?Type $x = nullacrossCompiler.php,Parser.php,Formatter.php,Node/Number.php, and related files.Test plan
scssphp/src/Version.phpreports1.13.0🤖 Generated with Claude Code