fix(organisations): the concept organisations widget lists draft organisations and accepts them - #1186
Merged
rubenvdlinde merged 2 commits intoSep 29, 2026
Conversation
…nisations and accepts them as Active The widget filtered on 'concept' and wrote 'actief'; neither is in the organization status enum (Draft, Active, Inactive, merged), so it listed nothing and every accept was refused. composer test:unit now points at phpunit-unit.xml instead of the missing tests/phpunit.xml.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 807/807 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-29 16:56 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect fix in shipped code, not a parity build. The
org-statusrow stays decided-no (phase A, #1172); this only repairs the widget that already ships.What was broken
ConceptOrganisatiesWidgetfiltered organisations on statusconceptand accepted them by writingactief. The organization schema's status enum isDraft,Active,Inactive,merged(defaultDraft), so the widget listed nothing and every accept would have been refused by OpenRegister's validator.Fix
src/utils/organisationStatus.js:CONCEPT_STATUS = 'Draft',ACCEPTED_STATUS = 'Active',isConceptOrganisation(),acceptPayload().composer test:unitpointed at a missingtests/phpunit.xml; it now runsphpunit -c phpunit-unit.xml.Tests (red first)
tests/vitest/organisationStatus.spec.js, written against the old values first: 3 of 4 red (expected [ 'Draft', 'Active', 'Inactive', …(1) ] to include 'concept', and the Ajv enum error on the accept payload). Green after the fix, plus a wiring test that reads the widget source and requires the helpers at the filter and the patch call. The accept payload is validated with Ajv against the realstatusproperty (type and enum) oflib/Settings/softwarecatalogus_register.json.Live check
Dashboard, add the concept organisations widget. An organisation with status
Draftis listed; Accept sets it toActive(PATCH 200) and it leaves the list.Inherited, not fixed here
PHP code still reads
actiefin places (OrganizationSyncServicecountsLOWER(o.status) = 'actief', which anActiveorganisation does not match). Separate defect, not in this diff.@SPEC openspec/specs/fe-organizations/spec.md
Gate run
check:strict 0, lint 0, stylelint 0, format 0, test:l10n 0, check:schema-l10n 0, check:l10n-js 0, check:manifest 0, check:vue-demi 0, jest 0, vitest 0, ci-gates (hydra-gates@main, full coverage) 0 (81/81). phpunit exit 2: the 20 inherited errors, identical by name to the lane baseline.