chore(softwarecatalog): remove two committed debug scripts - #487
Merged
Conversation
Task 5.2 of openspec/changes/english-vocabulary: the spec says DELETE these rather than rename them, because a committed debug script is not vocabulary worth migrating. Read both before removing. They are pure echo scripts from a 2026-05-29 debugging session — notes-to-self about why a contactpersoon's username looked empty. No queries, no credentials, no logic; nothing imports or executes them, and neither appears in phpcs.xml, phpmd.baseline.xml, psalm.xml, phpstan.neon, composer.json or any workflow. Two things worth noting on the way out. They hardcode a real-looking contactpersoon UUID, which is the sort of thing that should not sit in a public repo even when it is not a secret. And their whole premise was querying oc_openregister_objects, which is the EMPTY shared table — objects live in the per-schema oc_openregister_table_<reg>_<schema> shards, so the debugging session was reading the wrong place. That is the same lookup error that made a stored-object count report a false zero earlier in this programme. softwarecatalog's vocabulary rename itself is NOT in this commit: it is 6757 references across 194 files over roughly 9,500 imported VNG production records, and the spec requires the migration to be authored and tested against copied data before any rename merges.
Contributor
Quality Report — ConductionNL/softwarecatalog @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 128/128 | |||
| npm | ✅ | ✅ 718/718 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-11 19:17 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 5.2 of
openspec/changes/english-vocabulary. The spec says delete these rather than rename them — a committed debug script isn't vocabulary worth migrating.I read both before removing. They're pure
echoscripts from a 2026-05-29 debugging session — notes-to-self about why a contactpersoon's username looked empty. No queries, no credentials, no logic. Nothing imports or executes them, and neither appears inphpcs.xml,phpmd.baseline.xml,psalm.xml,phpstan.neon,composer.jsonor any workflow.Two things worth noting on the way out
They hardcode a real-looking contactpersoon UUID — the sort of thing that shouldn't sit in a public repo even when it isn't a secret.
And their whole premise was querying
oc_openregister_objects— the empty shared table. Objects live in the per-schemaoc_openregister_table_<reg>_<schema>shards, so that debugging session was reading the wrong place and would have found nothing regardless. It's the same lookup error that made a stored-object count report a false zero earlier in this programme, caught then by a positive control.Not in this PR
softwarecatalog's actual vocabulary rename: 6,757 references across 194 files, over roughly 9,500 imported VNG production records. The spec requires the migration to be authored and exercised against copied production data before any rename merges — this app cannot reseed, unlike the greenfield ones.
🤖 Generated with Claude Code