refactor(termijn): rename Ingebrekestelling{Service,Controller} to NoticeOfDefault* - #818
Merged
rubenvdlinde merged 1 commit intoAug 12, 2026
Conversation
…ticeOfDefault* Replaces #810, which was branched from a stale stack: its diff carried a dozen files that #803/#804/#806/#809/#816/#817 have since landed, so rebasing it meant resolving 8 conflicts across controllers, services, tests and a Postman collection. Branched fresh from development this does the same work as a 40-reference change across 10 files with zero conflicts. IngebrekestellingService -> NoticeOfDefaultService IngebrekestellingController -> NoticeOfDefaultController registerIngebrekestelling() -> registerNoticeOfDefault() ROUTE NAMES MOVE, URLs DO NOT. A route name resolves to its controller class, so `ingebrekestelling#register` had to become `noticeOfDefault#register` or the router 500s on that endpoint. The URLs stay `/api/termijn/ingebrekestellingen`: that is the published contract and moving it is a breaking change for every consumer — a separate decision from this rename. Both route names were verified to resolve to NoticeOfDefaultController.php after the change. NOT IN THIS CHANGE: the `ingebrekestelling` SCHEMA in 60-termijnbewaking.json, its reference property, and the `ingebrekestelling-ontvangen` lifecycle enum value. The schema is a data contract — renaming it needs an ownership check and a column migration, and the enum value is stored data. Class names carry no data and move independently, which is why this is a clean slice. VERIFIED - phpunit: 1882 tests, 6393 assertions green (5 skipped, same as baseline). - php -l clean on every changed file; the Postman collection still parses. - Route names resolve: both noticeOfDefault#* map to a file that exists. - Residual grep finds no IngebrekestellingService / IngebrekestellingController / registerIngebrekestelling anywhere in lib/, tests/ or appinfo/. - phpcs: 6 errors across the four changed files against a 386-error baseline. My edit added 5; phpcbf fixed those and cleared pre-existing debt with them.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 12, 2026 09:48
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 552/552 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 10:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #810.
#810 was branched from a stale stack. Its diff carried a dozen files that #803/#804/#806/#809/#816/#817 have since landed, so rebasing meant resolving 8 conflicts across controllers, services, tests and a Postman collection. Branched fresh from
development, the same work is 40 references across 10 files with zero conflicts.IngebrekestellingServiceNoticeOfDefaultServiceIngebrekestellingControllerNoticeOfDefaultControllerregisterIngebrekestelling()registerNoticeOfDefault()Route names move, URLs do not
A route name resolves to its controller class, so
ingebrekestelling#registerhad to becomenoticeOfDefault#registeror the router 500s on that endpoint. Both were verified to resolve toNoticeOfDefaultController.phpafter the change.The URLs stay
/api/termijn/ingebrekestellingen— that is the published contract, and moving it is a breaking change for every consumer. Separate decision from this rename.Not in this change
The
ingebrekestellingschema in60-termijnbewaking.json, its reference property, and theingebrekestelling-ontvangenlifecycle enum value. The schema is a data contract needing an ownership check and a column migration; the enum value is stored data. Class names carry no data and move independently — which is exactly what makes this a clean slice.Verification
php -lclean on every changed file; the Postman collection still parsesnoticeOfDefault#*map to a file that existsIngebrekestellingService/IngebrekestellingController/registerIngebrekestellinganywhere inlib/,tests/orappinfo/Once this merges, #810 should be closed unmerged.