chore(deps): pin @conduction/nextcloud-vue to 2.2.0-vue3.16 - #481
Merged
Conversation
Moves the pin from 2.2.0-vue3.9 to the current vue3 dist-tag. vue3.16 ships the shared scripts/ directory (13 check scripts including check-integration-parity.js) in the published tarball and fixes that checker so it can no longer report a pass while correlating nothing. This unblocks hydra gate-24, which on 2.2.0-vue3.9 cannot find its own checker and therefore verifies nothing. Lockfile regenerated with npm 10.8.2 to match the Node 20 / npm 10 toolchain used in CI; npm ci verified from a clean node_modules. Verified locally: npm run build, npm run test:unit (18 files / 283 tests), eslint and stylelint all pass. No call-site migration was needed.
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 549/549 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 22:40 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pin from
2.2.0-vue3.9to2.2.0-vue3.16, the currentvue3dist-tag — a seven-prerelease jump.Why
scripts/— 13 shared check scripts includingcheck-integration-parity.js— first appears in the published tarball at 2.2.0-vue3.14. On2.2.0-vue3.9this app ships hydra gate-24 with no checker to find, so the gate verifies nothing. vue3.16 additionally fixes that checker so it can no longer report a pass while correlating nothing.Confirmed present after install:
node_modules/@conduction/nextcloud-vue/scripts/with all 13 scripts.Lockfile
Regenerated with npm 10.8.2 to match the Node 20 / npm 10 toolchain CI uses. npm 11 drops nested entries under
node_modules/@nextcloud/vue/node_modules/that npm 10 keeps, which makesnpm cireject the lock and fails every npm job — including License and Security, which never touch Vue. Nested entry count unchanged at 15; total package count unchanged at 1259.npm civerified from a cleannode_modules.Exact pin retained deliberately — a caret on a prerelease line silently pulls in component changes.
Verification (measured locally, after the bump)
npm ci(clean tree)npm run buildnpm run test:unitnpm run lint(eslint)npm run stylelintEverything is green, so no
developmentcomparison was needed to attribute a failure. No call-site migration was required despite the seven-prerelease jump. Onlypackage.jsonandpackage-lock.jsonare touched.