chore(quality): point PHPMD at the central ruleset - #479
Merged
Conversation
phpmd.xml becomes a 9-line stub referencing vendor/conduction/hydra-gates/quality-config/phpmd.xml, and the local phpmd-unusedparams.xml is deleted in favour of the central copy, which the second leg of the composer phpmd script now points at. Both legs and the worst-exit-code behaviour are unchanged.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 12, 2026 20:40
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 548/548 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 21:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Step 2a of the Nextcloud CI/CD alignment, following the merged reference
larpingapp#314.
phpmd.xmlvendor/conduction/hydra-gates/quality-config/phpmd.xmlphpmd-unusedparams.xmlcomposer phpmdpoints at the central copyThe
phpmdscript keeps both legs and the worst-exit-code behaviour:Verification
phpmdon this app was already clean, so exit 0 proves nothing — a stub thatsilently scanned nothing produces exactly the same output. Two independent
checks were run instead.
1. The effective rule set, before and after
Dumped rule by rule through PHPMD's own
RuleSetFactory(class, rule name,priority,
since, and every resolved property), plus each ruleset's effective<exclude-pattern>set, resolved from the app root exactly as PHPMD resolves it:composer phpmdoutput is byte-identical before and after (0 findings, exit 0).2. Positive control — the second leg is alive
A scratch copy of
lib/was given three probe classes and the post-changescript re-run:
lib/ProbeControl/ProbeMainLeg.php— anelsebranchlib/ProbeControl/ProbeUnusedParam.php— an unused parameterlib/Migration/ProbeMigrationUnusedParam.php— same violationExit code
2, i.e. the run can still fail. The probes exist only in the scratchcopy; nothing in this diff.
Deliberately not in this PR
.github@main4c37371d), sodevelopmentalready carries this app's wholebacklog. This PR adds nothing to it;
phpmditself stays green.Quality Reportis an aggregator and never an independent defect.