chore: delete the inert .prettierrc - #478
Merged
Merged
Conversation
Nextcloud itself uses no prettier — nextcloud/server and nextcloud/text have no prettier dependency, no format script and no prettier config; they ship .editorconfig and enforce JS/Vue formatting through @nextcloud/eslint-config. In this repo the file never ran: no prettier dependency, no format script, no workflow reference. It only took effect in editors, where its 2-space indent and double quotes are exactly what @nextcloud/eslint-config then flags.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 12, 2026 18:54
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 548/548 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 19:28 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
.prettierrc.Why — and why this reverses an earlier instruction in this programme
"Wire up
.prettierrc" was on the original task list for the Nextcloud-alignmentwork. Measuring first changed the answer, so this removes the file instead. The
reasoning, so the decision can be re-opened if any of it is wrong:
1. Nextcloud does not use prettier. Checked directly, not assumed —
nextcloud/server@masterandnextcloud/text@mainhave no prettier dependency, noformatscript and no prettier config file. They ship.editorconfigand enforceJS/Vue formatting through
@nextcloud/eslint-config. (@nextcloud/prettier-configexists on npm at 1.2.0, but the flagship repos do not consume it.)
The policy this programme runs on is: our code must pass Nextcloud's checks; we may be
stricter, we may not be different. Adding a second JS formatter is not
stricter, it is different.
2. It is inert where it would help and active where it hurts. Measured across the
merged apps: zero have
prettierindependencies/devDependencies, zerodeclare a
formatorprettierscript, and zero workflows reference it. So itnever runs in CI. It does run in editors — where it sets 2-space indent and double
quotes, both of which
@nextcloud/eslint-configthen flags. A contributor who saves afile gets it reformatted into a state the linter rejects.
3.
.editorconfigalready owns this. Nextcloud's own.editorconfigwas adoptedfleet-wide earlier in this programme and is the file both editors and php-cs-fixer
agree on.
Blast radius
None in CI: no job invokes prettier, so no check changes behaviour. The only effect is
that editors stop applying a config that contradicts the linter.
If prettier is wanted later, the aligned way is
@nextcloud/prettier-configwired intoa real
formatscript and a CI leg — not an unreferenced dotfile.