Skip to content

chore: delete the inert .prettierrc - #478

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/drop-inert-prettierrc
Aug 12, 2026
Merged

chore: delete the inert .prettierrc#478
rubenvdlinde merged 1 commit into
developmentfrom
chore/drop-inert-prettierrc

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

Deletes .prettierrc.

Why — and why this reverses an earlier instruction in this programme

"Wire up .prettierrc" was on the original task list for the Nextcloud-alignment
work. Measuring first changed the answer, so this removes the file instead. The
reasoning, so the decision can be re-opened if any of it is wrong:

1. Nextcloud does not use prettier. Checked directly, not assumed —
nextcloud/server@master and nextcloud/text@main have no prettier dependency, no
format script and no prettier config file
. They ship .editorconfig and enforce
JS/Vue formatting through @nextcloud/eslint-config. (@nextcloud/prettier-config
exists on npm at 1.2.0, but the flagship repos do not consume it.)

The policy this programme runs on is: our code must pass Nextcloud's checks; we may be
stricter, we may not be different.
Adding a second JS formatter is not
stricter, it is different.

2. It is inert where it would help and active where it hurts. Measured across the
merged apps: zero have prettier in dependencies/devDependencies, zero
declare a format or prettier script, and zero workflows reference it. So it
never runs in CI. It does run in editors — where it sets 2-space indent and double
quotes, both of which @nextcloud/eslint-config then flags. A contributor who saves a
file gets it reformatted into a state the linter rejects.

3. .editorconfig already owns this. Nextcloud's own .editorconfig was adopted
fleet-wide earlier in this programme and is the file both editors and php-cs-fixer
agree on.

Blast radius

None in CI: no job invokes prettier, so no check changes behaviour. The only effect is
that editors stop applying a config that contradicts the linter.

If prettier is wanted later, the aligned way is @nextcloud/prettier-config wired into
a real format script and a CI leg — not an unreferenced dotfile.

Nextcloud itself uses no prettier — nextcloud/server and nextcloud/text have no
prettier dependency, no format script and no prettier config; they ship
.editorconfig and enforce JS/Vue formatting through @nextcloud/eslint-config.

In this repo the file never ran: no prettier dependency, no format script, no
workflow reference. It only took effect in editors, where its 2-space indent and
double quotes are exactly what @nextcloud/eslint-config then flags.
@rubenvdlinde
rubenvdlinde merged commit 3f53523 into development Aug 12, 2026
35 of 36 checks passed
@rubenvdlinde
rubenvdlinde deleted the chore/drop-inert-prettierrc branch August 12, 2026 19:10
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/decidesk @ 9b69c0b

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
test-l10n
composer ✅ 104/104
npm ✅ 548/548
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-12 19:28 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant