Skip to content

fix(ci): test the whole declared Nextcloud range, not only the ceiling - #477

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/test-declared-nc-range
Aug 12, 2026
Merged

fix(ci): test the whole declared Nextcloud range, not only the ceiling#477
rubenvdlinde merged 1 commit into
developmentfrom
fix/test-declared-nc-range

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

nextcloud-test-refs becomes '["stable34", "stable32", "stable33"]' — every
major inside the range appinfo/info.xml declares.

Why

appinfo/info.xml declares <nextcloud min-version="32" max-version="34"/>,
and development currently tests stable34 only. So 32 and 33 are
advertised to the App Store with no job touching either — not known-broken,
unmeasured.

This is the coding-standard migration's own defect. Its rollout script did:

re.sub(r"nextcloud-test-refs: '\[[^\]]*\]'", '''nextcloud-test-refs: '["stable34"]'''', t)

which replaces the list instead of extending it. The programme opened by
reporting that nothing was tested on NC 34 and, in fixing that, made the
declared floor the untested end. Same defect, other direction.

Several apps' comments recorded the intent correctly while the value
contradicted them — larpingapp, decidesk and procest all said "stable33 is
deliberately NOT added: this removes an impossible leg, it does not widen the
matrix"
, but the same change had also dropped stable32, which was not an
impossible leg, it was the floor. Those comments are corrected here too, along
with two that had simply rotted: scholiq claimed a min-version of 33 and
launchpad a floor of 29, where both files now declare 32.

Evidence

Verified on portaliq, which already runs all three refs against
nextcloud/ocp ^34 — run 31599055849, six PHPUnit legs green:

success  PHPUnit (PHP 8.3, NC stable32, pgsql)   success  PHPUnit (PHP 8.4, NC stable32, pgsql)
success  PHPUnit (PHP 8.3, NC stable33, pgsql)   success  PHPUnit (PHP 8.4, NC stable33, pgsql)
success  PHPUnit (PHP 8.3, NC stable34, pgsql)   success  PHPUnit (PHP 8.4, NC stable34, pgsql)

stable34 stays first: newman, playwright and journeydoc-capture all read
fromJSON(inputs.nextcloud-test-refs)[0] as their single server.

Reviewing this

The added legs are the point — do not merge this on the strength of the diff.
If a stable32 or stable33 leg goes red here, that is this app failing on a
version it already claims to support, and it is a finding, not noise.

appinfo/info.xml declares <nextcloud min-version="32" max-version="34"/>, but
nextcloud-test-refs was '["stable34"]' — so the declared floor and the middle
major were advertised to the App Store with no job touching either.

This is the coding-standard migration's own defect: its rollout REPLACED the
ref list instead of extending it. The programme opened by reporting that
nothing was tested on NC 34 and, in fixing that, made 32 and 33 the untested
end. Same drift, other direction.

stable34 stays first because newman, playwright and journeydoc-capture all read
fromJSON(inputs.nextcloud-test-refs)[0] as their single server.

Verified green on all three refs against nextcloud/ocp ^34 on portaliq
(run 31599055849, six PHPUnit legs: 32/33/34 x PHP 8.3/8.4).
@rubenvdlinde
rubenvdlinde merged commit c765391 into development Aug 12, 2026
35 of 36 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/test-declared-nc-range branch August 12, 2026 18:35
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/decidesk @ 5b64681

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
test-l10n
composer ✅ 104/104
npm ✅ 548/548
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-12 18:40 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant