fix(ci): test the whole declared Nextcloud range, not only the ceiling - #477
Merged
Conversation
appinfo/info.xml declares <nextcloud min-version="32" max-version="34"/>, but nextcloud-test-refs was '["stable34"]' — so the declared floor and the middle major were advertised to the App Store with no job touching either. This is the coding-standard migration's own defect: its rollout REPLACED the ref list instead of extending it. The programme opened by reporting that nothing was tested on NC 34 and, in fixing that, made 32 and 33 the untested end. Same drift, other direction. stable34 stays first because newman, playwright and journeydoc-capture all read fromJSON(inputs.nextcloud-test-refs)[0] as their single server. Verified green on all three refs against nextcloud/ocp ^34 on portaliq (run 31599055849, six PHPUnit legs: 32/33/34 x PHP 8.3/8.4).
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 12, 2026 18:01
Contributor
Quality Report — ConductionNL/decidesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 548/548 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-12 18:40 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nextcloud-test-refsbecomes'["stable34", "stable32", "stable33"]'— everymajor inside the range
appinfo/info.xmldeclares.Why
appinfo/info.xmldeclares<nextcloud min-version="32" max-version="34"/>,and
developmentcurrently tests stable34 only. So 32 and 33 areadvertised to the App Store with no job touching either — not known-broken,
unmeasured.
This is the coding-standard migration's own defect. Its rollout script did:
which replaces the list instead of extending it. The programme opened by
reporting that nothing was tested on NC 34 and, in fixing that, made the
declared floor the untested end. Same defect, other direction.
Several apps' comments recorded the intent correctly while the value
contradicted them — larpingapp, decidesk and procest all said "stable33 is
deliberately NOT added: this removes an impossible leg, it does not widen the
matrix", but the same change had also dropped stable32, which was not an
impossible leg, it was the floor. Those comments are corrected here too, along
with two that had simply rotted: scholiq claimed a min-version of 33 and
launchpad a floor of 29, where both files now declare 32.
Evidence
Verified on portaliq, which already runs all three refs against
nextcloud/ocp ^34— run 31599055849, six PHPUnit legs green:stable34stays first: newman, playwright and journeydoc-capture all readfromJSON(inputs.nextcloud-test-refs)[0]as their single server.Reviewing this
The added legs are the point — do not merge this on the strength of the diff.
If a stable32 or stable33 leg goes red here, that is this app failing on a
version it already claims to support, and it is a finding, not noise.