ci: rename branch-protection caller job id to branch-protection - #390
ci: rename branch-protection caller job id to branch-protection#390rubenvdlinde wants to merge 1 commit into
branch-protection#390Conversation
…ction` GitHub names a reusable-workflow status context `<caller-job-id> / <called-job-name>`, so this caller reported as `protect / check-branch` while the org ruleset requires `branch-protection / check-branch`. Also repoints the reusable workflow from `Conduction/.github` to `ConductionNL/.github`. The `Conduction` org does not exist (404), so on this branch the workflow could not resolve at all — a second, independent reason the required context never reported.
|
Reviewed as part of today's open-PR sweep. Correct and worth landing — but its base is One thing worth surfacing: the diff does more than the title says, and the undeclared part is the more important half. The title is "rename branch-protection caller job id". The diff also changes the org: - uses: Conduction/.github/.github/workflows/branch-protection.yml@main
+ uses: ConductionNL/.github/.github/workflows/branch-protection.yml@mainMeasured just now:
So Both halves are correct. Flagging the title/diff mismatch only so the org fix is reviewed deliberately rather than merged as a rename.
|
GitHub names a reusable-workflow status context
<caller-job-id> / <called-job-name>.This branch's caller job id was not
branch-protection, so the shared branch-protectionworkflow reported under the wrong context name, and the org ruleset requirement
branch-protection / check-branchnever reported at all — not as a failure, as nothing.Several of these beta branches carry a second, independent fault: the reusable workflow was
referenced as
Conduction/.githubinstead ofConductionNL/.github. TheConductionorg does notexist (
GET /repos/Conduction/.github-> 404), so on those branches the workflow could not evenresolve. Where present, that is fixed here too — renaming the job id alone would not have made the
context appear.
This matters for
beta -> mainpromotion PRs, whose head isbeta, so beta's tip is whatdecides the context name and the workflow reference.
Does not change what is required and does not touch any ruleset or branch protection.