Skip to content

fix: Only show eligible voters if the poll is not gatekept - #125

Merged
BigSpaceships merged 1 commit into
ComputerScienceHouse:devfrom
NickJ-7010:hide-votes
Oct 6, 2026
Merged

BigSpaceships merged 1 commit into
ComputerScienceHouse:devfrom
NickJ-7010:hide-votes

Conversation

@NickJ-7010

Copy link
Copy Markdown

What

what the PR changes

  • Changes the results template to only show the number of eligible voters if the poll requires gatekeep.

Why

why these changes were made

Test Plan

how did you verify these changes did what you expected

I tested against polls that required gatekeep and polls that didn't to make sure it showed up in the right context.

Env Vars

did you add, remove, or rename any environment variables

No

Documentation

did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.

No

Checklist

  • Tested all changes locally

@datadog-computersciencehouse

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

Your PR has warnings. Please review the issues below.

🚦 1 Pipeline job failed

SonarQube | Build and analyze

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6500769 | Docs | View more details | Give us feedback!

@BigSpaceships BigSpaceships left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@BigSpaceships
BigSpaceships merged commit 2a2e3dc into ComputerScienceHouse:dev Oct 6, 2026
1 of 2 checks passed
@NickJ-7010
NickJ-7010 deleted the hide-votes branch October 6, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants