Filter stack and radial covar optimizations#1388
Draft
garrettwrong wants to merge 50 commits into
Draft
Conversation
[skip ci]
warning sysetm needs improving
still needs cleanup
[skip ci]
[skip ci]
need to add legacy branch logic for other basis [skip ci]
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1388 +/- ##
===========================================
- Coverage 90.68% 90.45% -0.24%
===========================================
Files 135 135
Lines 14663 14926 +263
===========================================
+ Hits 13297 13501 +204
- Misses 1366 1425 +59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts code towards filter stacks while maintaining ability to use legacy single filters (for now).
Provides a
to_radialmethod for Filters.Provides means to mix most singleton and stack filters. Vectorizes bulk evaluations.
Tries to vectorize (and sometimes use GPU when things fit) for
filter_statck_to_basis_mats.Add code paths to run radially optimized
filter_stack_to_basis_mat.Adds a smoke/timing test for covar2d using 10028 (ribsome) and 11618 (ctf per image) experimental sized cases.
Still a WIP, need self review.