Repository navigation
Use bundle ID com.substratalapps.hub, shared with macOS - #2
Merged
Merged
Conversation
The Hub's iOS and macOS apps must share one bundle ID (Universal Purchase), because app_hub has a single APNs credential whose topic is that ID (Hub spec CLIENT-ARCHITECTURE §2, §6.2). macOS, Android and Linux already use com.substratalapps.*; iOS used com.substratal.hub. Renames the app, UI-test target, URL type name, and the Keychain service (com.substratalapps.hub.session, the same as macOS). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS and macOS Hub apps must share one bundle ID (Universal Purchase), because
app_hubholds a single APNs credential whosetopicis that ID (Hub spec CLIENT-ARCHITECTURE §2 and §6.2; macOSdocs/PREREQUISITES.mdflagged this as open). macOS (com.substratalapps.hub), Android (com.substratalapps.hub) and Linux (com.substratalapps.Hub) already agree; iOS usedcom.substratal.hub.project.ymland the regeneratedSubstratalHub.xcodeproj: appcom.substratalapps.hub, UI testscom.substratalapps.hub.uitests, URL type name.Info.plistURL type name.KeychainStoredefault service:com.substratalapps.hub.session, the same as macOS. Simulator sessions saved under the old name just need a fresh sign-in.MakefileandREADME.mdsimctl launchcommands.Verified:
xcodegen generatereproduces the committed project;xcodebuildfor the iOS Simulator succeeds and the built app'sCFBundleIdentifieriscom.substratalapps.hub;swift testin SubstratalKit passes (13 tests).Apple Developer portal / App Store Connect steps (register the App ID with Push Notifications; one app record for iOS + macOS) are manual and listed in the API repo issue #25.
🤖 Generated with Claude Code