feat(lists): move Add Item button to toolbar beside Watchers#7
Merged
Conversation
CrossPostResult.platform and .success were non-optional, so a server response missing the platform key caused a DecodingError that failed the whole CreateMessageResponse decode — showing "Connection failed" even though the post succeeded. Made both fields optional with safe fallbacks. Also logs the real error in the generic catch block and surfaces the server error string in the cross-post status toast. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the inline "Add Item" section from the list body and promote it to a toolbar button (plus icon) placed at topBarTrailing, left of the existing Watchers button. Disabled state when schema is empty is preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the "Add Item" button in
ListDetailViewfrom an inline list section at the bottom of the items list into the navigation toolbar, placed to the left of the existing Watchers button.What's included
Section { Button { "Add Item" } }from the list body (commit a2a1a53)ToolbarItem(placement: .topBarTrailing)with aplusicon button that triggersshowAddItem; disabled whenschema.isEmptymatches prior behaviorTesting
showAddItem,.disabled(schema.isEmpty),.accessibilityLabel) is identical to the removed section🤖 Generated with Claude Code