-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Chore: Add missing documentation for limits in tools.get #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Document limits for
|
|
The Please review and fix the vulnerabilities. You can try running: pnpm audit --fix --prodAudit output |
| :param scopes: Optional list of scopes to filter tools by. | ||
| :param limit: Optional limit on the number of tools to return. Defaults to 20 if not provided when using toolkits or search filters. Maximum value is 999. | ||
| :return: List of tool schemas matching the provided filters. | ||
| :raises InvalidParams: If none of `tools`, `search`, or `toolkits` are provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python SDK missing limit cap for specific tools
The TypeScript SDK enforces a maximum limit of 999 when fetching specific tools by slug (line 351), but the Python SDK doesn't apply this same cap when calling tools.list() with tool_slugs parameter (lines 150-155). This creates inconsistent behavior between SDKs and contradicts the PR's stated goal to "cap the tools to 999." The Python implementation should enforce the same limit override as TypeScript.
Documents tools.get() with available limits across python and ts SDK and cap the tools to 999 instead of 9999 to match API requirements
Closes #2138