Harden filter evaluation and command execution#14591
Open
shawndwells wants to merge 1 commit intoComplianceAsCode:masterfrom
Open
Harden filter evaluation and command execution#14591shawndwells wants to merge 1 commit intoComplianceAsCode:masterfrom
shawndwells wants to merge 1 commit intoComplianceAsCode:masterfrom
Conversation
shawndwells
requested review from
Mab879,
ggbecker,
jan-cerny,
marcusburghardt,
matusmarhefka and
vojtapolasek
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
safe_evaluate_boolean_filter--> stop allowing the build system to process arbitrary commands. Will take boolean operators, comparisons, and simple value strings/tuples/lists/sets, but remove various code execution risks from those filter expressions. We (Mission IT) use various build and CI/CD systems and want to remove risks of hosting ComplianceAsCode builders._validate_github_identifier--> checks repo names only have safe charactersthe old eval() paths could execute unintended python if a filter string was malicious
os.system() path risks command injection
Rationale:
Various fixes to help minimize the risks of hosting ComplianceAsCode build systems.