Symmetrization M1: derive orbital-op U_S from H0 (shadow mode)#368
Open
tylersax wants to merge 2 commits into
Open
Symmetrization M1: derive orbital-op U_S from H0 (shadow mode)#368tylersax wants to merge 2 commits into
tylersax wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive each point-group operation's orbital transform U_S directly from H0(k), replacing the hand-coded transformationSignOf* lookups, and verify it against the deterministic G0 oracle. All shadow-mode: nothing consumes the record for imposition yet, so production output is unchanged.
solve_orbital_op_signs.hpp(new): U_S = D.P, where the band permutation P is the geometry-given symmetry-table image and the +/-1 signs D are solved from the H0 coupling constraints by enumerate-and-verify.cluster_symmetry: add shadow accessors get_mapped_point and get_orbital_op.set_symmetry_matrices: populate mapped_point (the band-independent momentum image, ".first" promoted out of the symmetry-matrix pair).Integration test: add
PerOpMapMomentumUS(ensure U_S is well formed),GroupShadowCrossCheck(the H0-verified group equals the declared group on every shipped model),MappedPointShadow, and synthetic H0 rejection fixtures covering all three throw branches. Note these are designed under the assumption that we will encounter more complex forms of H0 in the material models.Candidates still come from the declared point group, so DCA_point_group is the shadow oracle.
Mini-roadmap
Snapshot of where we are in the project (subject to change):
M0: Characterization harness