Avoid redundant pgvector extension creation - #50
Merged
adamsitnik merged 7 commits intoAug 31, 2026
Merged
Conversation
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #49 by changing PgVector collection creation to avoid executing CREATE EXTENSION IF NOT EXISTS vector when the vector extension is already installed, enabling EnsureCollectionExistsAsync to succeed under roles that lack CREATE EXTENSION privileges.
Changes:
- Split pgvector extension existence detection from extension creation to avoid privilege failures when the extension is preinstalled.
- Added a helper (
IsVectorExtensionInstalledAsync) to probe for extension presence, and refined exception handling for concurrent installs/insufficient privileges. - Bumped
CommunityToolkit.VectorData.PgVectorpackage version to1.0.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MEVD/src/PgVector/PostgresCollection.cs | Avoids redundant extension creation by checking for vector first and only creating when absent. |
| MEVD/src/PgVector/PgVector.csproj | Increments package version to reflect the behavioral fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #49