Skip to content

fix(ci): Resolve existing grey-color violations blocking pre-push checks #15

Open

Description

@payown

Problem

The repository's pre-push bun run check reportedly fails on the unmodified main branch because script/check-greys.ts identifies 172 grey-color violations, all in services/site.

This was encountered while preparing PR #14, which only changes accessibility labels elsewhere. The contributor reports having to push with --no-verify to bypass this unrelated failure.

Note: The 172 count and reproduction on main are reported in PR #14; they have not yet been independently reproduced for this issue.

Expected behavior

  • A clean checkout of main should pass the repository's configured checks.
  • Contributors making unrelated changes should not have to bypass the pre-push hook.
  • The grey-color validation should continue to enforce the site's intended shared color scale.

Steps to investigate

  1. On a clean, up-to-date main checkout, run bun script/check-greys.ts and bun run check.
  2. Confirm the number and locations of existing violations under services/site.
  3. Resolve the underlying CSS/token violations, or document narrowly justified exceptions according to the script's rules. Do not simply disable the checker.
  4. Verify the full check passes and that unrelated PRs can push without --no-verify.

Context

The root package.json includes bun script/check-greys.ts in its lint script, which is run by bun run check. See the report in PR #14's verification notes.

This issue is separate from the screen-reader label fix in PR #14.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions