Upgrade to Gradle 9 and generate lockfiles

.github/workflows/verify.yml

@@ -0,0 +1,69 @@
+name: Test Build
+
+on:
+  push:
+    branches:
+      - '*'
+    tags-ignore:
+      - '*'
+  pull_request:
+    branches:
+      - '*'
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: GithubPasswordManager
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Set up JDK 25
+      uses: actions/setup-java@v4
+      with:
+        distribution: zulu
+        java-version: '25'
+
+    - name: Set up Gradle
+      uses: gradle/actions/setup-gradle@v4
+      with:
+        gradle-version: '9.1.0'
+
+    - name: Test with Gradle
+      run: gradle --no-daemon test
+
+  # Catch dependency changes that would make the lockfile inconsistent.
+  # Regenerate after a dependency change and commit the result:
+  #   cd GithubPasswordManager && ./gradlew --write-locks lockClasspaths
+  lockfile-drift:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: GithubPasswordManager
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Set up JDK 25
+      uses: actions/setup-java@v4
+      with:
+        distribution: zulu
+        java-version: '25'
+
+    - name: Set up Gradle
+      uses: gradle/actions/setup-gradle@v4
+      with:
+        gradle-version: '9.1.0'
+
+    - name: Regenerate lockfiles
+      run: gradle --no-daemon --write-locks lockClasspaths
+
+    - name: Fail if lockfile changed
+      run: |
+        if ! git diff --exit-code -- '**/gradle.lockfile' 'gradle.lockfile'; then
+          echo "::error::gradle.lockfile is out of date. Regenerate it and commit the result:"
+          echo "  gradle --write-locks lockClasspaths"
+          exit 1
+        fi

.gitignore

@@ -12,6 +12,8 @@
 
 # Package Files #
 *.jar
+# ...except the Gradle wrapper, which must be committed to make ./gradlew work
+!**/gradle/wrapper/gradle-wrapper.jar
 *.war
 *.nar
 *.ear

GithubPasswordManager/.gitattributes

@@ -1,2 +1,6 @@
 * text=auto eol=lf
-*.java eol=lf
+*.java eol=lf
+
+# Gradle dependency lockfiles are generated with LF and are hash-sensitive:
+# a CRLF checkout would change every line and invalidate the lock.
+gradle.lockfile text eol=lf

GithubPasswordManager/build.gradle

@@ -85,4 +85,40 @@ publishing {
 
 signing {
 	sign publishing.publications.mavenJava
-}
+}
+
+// Regenerate after any dependency change:
+//   ./gradlew --write-locks lockClasspaths
+allprojects {
+	dependencyLocking {
+		lockAllConfigurations()
+	}
+}
+
+def lockedConfigurations = [
+	'annotationProcessor',
+	'compileClasspath',
+	'runtimeClasspath',
+	'testCompileClasspath',
+	'testRuntimeClasspath',
+]
+
+allprojects {
+	tasks.register('lockClasspaths') {
+		group = 'build'
+		description = 'Resolve the locked configurations so --write-locks records them'
+		doLast {
+			lockedConfigurations.each { n ->
+				def c = configurations.findByName(n)
+				if (c != null && c.canBeResolved) {
+					try {
+						c.resolve()
+					} catch (Throwable ignored) {
+						// A configuration that cannot resolve is still recorded by
+						// --write-locks; failure here must not abort the task.
+					}
+				}
+			}
+		}
+	}
+}

GithubPasswordManager/gradle.lockfile

@@ -0,0 +1,41 @@
+# This is a Gradle generated file for dependency locking.
+# Manual edits can break the build and are not advised.
+# This file is expected to be part of source control.
+com.fasterxml.jackson.core:jackson-annotations:2.10.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.fasterxml.jackson.core:jackson-core:2.10.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.fasterxml.jackson.core:jackson-databind:2.10.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.google.crypto.tink:tink:1.3.0-rc1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.google.protobuf:protobuf-java:3.8.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+com.googlecode.javaewah:JavaEWAH:1.1.13=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+commons-codec:commons-codec:1.13=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+commons-io:commons-io:2.6=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+commons-logging:commons-logging:1.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+javax.servlet:javax.servlet-api:3.1.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+junit:junit:4.10=testCompileClasspath,testRuntimeClasspath
+net.i2p.crypto:eddsa:0.3.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.commons:commons-lang3:3.9=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.httpcomponents:httpclient:4.5.14=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.httpcomponents:httpcore:4.4.16=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.sshd:sshd-common:2.7.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.sshd:sshd-core:2.7.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.sshd:sshd-osgi:2.7.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.apache.sshd:sshd-sftp:2.7.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty.orbit:javax.servlet:3.0.0.v201112011016=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-continuation:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-http:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-io:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-security:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-server:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-servlet:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-servlets:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-util:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-webapp:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jetty:jetty-xml:9.0.2.v20130417=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jgit:org.eclipse.jgit.ssh.apache:5.13.1.202206130422-r=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.eclipse.jgit:org.eclipse.jgit:5.13.1.202206130422-r=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.hamcrest:hamcrest-core:1.1=testCompileClasspath,testRuntimeClasspath
+org.json:json:20180813=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.kohsuke:github-api:1.101=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.slf4j:jcl-over-slf4j:1.7.30=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+org.slf4j:slf4j-api:1.7.30=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
+empty=annotationProcessor

GithubPasswordManager/gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,7 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-5.0-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.1.0-bin.zip
+networkTimeout=10000
+validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists