Correctly handle multi-packet PAT#182
Open
julijane wants to merge 1 commit into
Open
Conversation
The old code did not handle PAT which do not fit into single packet correctly. This adds a PAT accumulator and fixes ReadPAT to use that. A test using a multi packet PAT (real-world data) and tests for the accumulator were added.
julijane
force-pushed
the
juli/handle-multi-pkt-pat
branch
from
f2b94df to
9e6d28f
Compare
Author
|
Question to the maintainers: The new accumulator function is not really something new, it is the same code as in PmtAccumulatorDoneFunc. Instead of duplicating the code the existing function might be renamed maybe into for example WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code did not handle PAT which do not fit into single packet correctly. This adds a PAT accumulator and fixes ReadPAT to use that. A test using a multi packet PAT (real-world data) and tests for the accumulator were added.