Fix completely empty table cells causing Word errors #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stesee
approved these changes
Jan 22, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocumentAssembler can leave table cells entirely empty, which causes Word to complain about an invalid file when opening it. Table cells are not expected to be completely empty; every table cell is expected to have at least one block-level element in it (such as an empty paragraph).
However, when DocumentAssembler assembles Conditional tags, and the Conditional tag causes content to be removed from a table cell, the cell is indeed left completely empty -- leading to errors in Word.
This PR enhances DocumentAssembler so it checks assembled table cells to ensure they are left with at least one block-level element in them, and if not, it adds an empty paragraph so Word does not complain about the file when it is opened.