Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to simplify the NuGet push and GitHub release commands by removing explicit path prefixes from the file patterns. However, this simplification introduces critical bugs that will cause deployment failures.
Key Changes
- Simplified
dotnet nuget pushcommand paths from./OpenXmlPowerTools/bin/Release/*.nupkgto*.nupkg - Simplified
gh release createcommand paths from./OpenXmlPowerTools/bin/Release/*.*nupkgto*.*nupkg - Applied these changes to both the
deployReleaseanddeployTestjobs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if: env.NUGET_TOKEN_EXISTS != '' | ||
| run: | | ||
| dotnet nuget push ./OpenXmlPowerTools/bin/Release/*.nupkg --skip-duplicate --api-key ${{secrets.NUGET_TOKEN}} --source https://api.nuget.org/v3/index.json | ||
| dotnet nuget push *.nupkg --skip-duplicate --api-key ${{secrets.NUGET_TOKEN}} --source https://api.nuget.org/v3/index.json |
There was a problem hiding this comment.
The simplified path *.nupkg will not find the NuGet packages. The build artifacts are uploaded from OpenXmlPowerTools/bin/Release/ (line 39), but when downloaded using actions/download-artifact@v6, they are extracted to the current working directory without preserving the original path structure. The *.nupkg pattern searches in the current directory, but the packages will be in OpenXmlPowerTools/bin/Release/ subdirectory. This command will fail with a "No packages found" error.
| if: env.GITHUB_TOKEN != '' | ||
| run: | | ||
| gh release create ${{env.CURRENT_VERSION}} ./OpenXmlPowerTools/bin/Release/*.*nupkg --generate-notes | ||
| gh release create ${{env.CURRENT_VERSION}} *.*nupkg --generate-notes |
There was a problem hiding this comment.
The simplified path *.*nupkg will not find the NuGet packages. The build artifacts are uploaded from OpenXmlPowerTools/bin/Release/ (line 39), but when downloaded using actions/download-artifact@v6, they are extracted to the current working directory without preserving the original path structure. The *.*nupkg pattern searches in the current directory, but the packages will be in OpenXmlPowerTools/bin/Release/ subdirectory. This command will fail with a "No such file or directory" error.
| run: | | ||
| ls ./OpenXmlPowerTools/bin/Release | ||
| dotnet nuget push ./OpenXmlPowerTools/bin/Release/*.nupkg --skip-duplicate --api-key ${{secrets.NUGET_TEST_TOKEN}} --source https://apiint.nugettest.org/v3/index.json | ||
| dotnet nuget push *.nupkg --skip-duplicate --api-key ${{secrets.NUGET_TEST_TOKEN}} --source https://apiint.nugettest.org/v3/index.json |
There was a problem hiding this comment.
The simplified path *.nupkg will not find the NuGet packages. The build artifacts are uploaded from OpenXmlPowerTools/bin/Release/ (line 39), but when downloaded using actions/download-artifact@v6, they are extracted to the current working directory without preserving the original path structure. The *.nupkg pattern searches in the current directory, but the packages will be in OpenXmlPowerTools/bin/Release/ subdirectory. This command will fail with a "No packages found" error. Note that line 86 still has the correct path, which shows the expected location of the files.
| if: env.GITHUB_TOKEN != '' | ||
| run: | | ||
| gh release create ${{env.CURRENT_VERSION}} ./OpenXmlPowerTools/bin/Release/*.*nupkg --prerelease --generate-notes | ||
| gh release create ${{env.CURRENT_VERSION}} *.*nupkg --prerelease --generate-notes |
There was a problem hiding this comment.
The simplified path *.*nupkg will not find the NuGet packages. The build artifacts are uploaded from OpenXmlPowerTools/bin/Release/ (line 39), but when downloaded using actions/download-artifact@v6, they are extracted to the current working directory without preserving the original path structure. The *.*nupkg pattern searches in the current directory, but the packages will be in OpenXmlPowerTools/bin/Release/ subdirectory. This command will fail with a "No such file or directory" error.
1 participant
No description provided.