Skip to content

FlxView3D (Away3D) Optimisation #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kitzsh wants to merge 8 commits into
base: main
Choose a base branch
from
+350 −78
Open

FlxView3D (Away3D) Optimisation #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a4546c5
Initial commit for branch
kitzsh Jan 9, 2026
f412b3c
Almost done, just need to fix that weird bug where 2 views need to be…
kitzsh Jan 9, 2026
9961b07
Small optimisations
kitzsh Jan 9, 2026
0b978bd
Added temporary fix for rendering with a single view
kitzsh Jan 10, 2026
f5d508b
removed myself from the authors
kitzsh Jan 10, 2026
d699fde
Removing it in fact did not break anything (removed commented out blo…
kitzsh Jan 10, 2026
2d24df3
Removed a useless variable and improved formatting on a comment
kitzsh Jan 10, 2026
1a94243
Aw dang it
kitzsh Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 52 additions & 31 deletions source/flx3d/Flx3DCamera.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,25 @@ import flx3d.Flx3DUtil;
import haxe.io.Path;
import openfl.Assets;
#end

import flixel.FlxCamera;

class Flx3DCamera extends FlxCamera {
class Flx3DCamera extends FlxCamera
{
#if THREE_D_SUPPORT
private static var __3DIDS:Int = 0;

public var view:View3D;

var meshes:Array<Mesh> = [];
public function new(X:Int = 0, Y:Int = 0, Width:Int = 0, Height:Int = 0, DefaultZoom:Float = 1) {

public function new(X:Int = 0, Y:Int = 0, Width:Int = 0, Height:Int = 0, DefaultZoom:Float = 1)
{
if (!Flx3DUtil.is3DAvailable())
throw "[Flx3DCamera] 3D is not available on this platform. Stages in use: " + Flx3DUtil.getTotal3D() + ", Max stages allowed: " + FlxG.stage.stage3Ds.length + ".";
throw "[Flx3DCamera] 3D is not available on this platform. Stages in use: "
+ Flx3DUtil.getTotal3D()
+ ", Max stages allowed: "
+ FlxG.stage.stage3Ds.length
+ ".";
super(X, Y, Width, Height, DefaultZoom);
__cur3DStageID = __3DIDS++;

Expand All @@ -49,7 +55,8 @@ class Flx3DCamera extends FlxCamera {
FlxG.stage.addChild(view);
}

public override function render() {
public override function render()
{
super.render();

view.x = FlxG.game.x + FlxG.game.scaleX * (flashSprite.x + flashSprite.scaleX * (_scrollRect.x + _scrollRect.scaleX * (_scrollRect.scrollRect.x)));
Expand All @@ -65,7 +72,8 @@ class Flx3DCamera extends FlxCamera {
view.render();
}

public function addModel(assetPath:String, callback:Asset3DEvent->Void, ?texturePath:String, smoothTexture:Bool = true) {
public function addModel(assetPath:String, callback:Asset3DEvent->Void, ?texturePath:String, smoothTexture:Bool = true)
{
var model = Assets.getBytes(assetPath);
if (model == null)
throw 'Model at ${assetPath} was not found.';
Expand All @@ -79,36 +87,43 @@ class Flx3DCamera extends FlxCamera {
if (texturePath != null)
material = new TextureMaterial(Cast.bitmapTexture(Assets.getBitmapData(texturePath, true, false)), smoothTexture);

return loadData(model, context, switch(Path.extension(assetPath).toLowerCase()) {
return loadData(model, context, switch (Path.extension(assetPath).toLowerCase())
{
case "dae": new DAEParser();
case "md2": new MD2Parser();
case "md5": new MD5MeshParser();
case "awd": new AWDParser();
default: new OBJParser();
}, (event:Asset3DEvent) -> {
if (event.asset != null && event.asset.assetType == Asset3DType.MESH) {
var mesh:Mesh = cast event.asset;
if (material != null)
mesh.material = material;
meshes.push(mesh);
}
callback(event);
});
default: new OBJParser();
}, (event:Asset3DEvent) ->
{
if (event.asset != null && event.asset.assetType == Asset3DType.MESH)
{
var mesh:Mesh = cast event.asset;
if (material != null)
mesh.material = material;
meshes.push(mesh);
}
callback(event);
});
}

private var __cur3DStageID:Int;
private var _loaders:Map<Asset3DLibraryBundle, AssetLoaderToken> = [];

private function loadData(data:Dynamic, context:AssetLoaderContext, parser:ParserBase, onAssetCallback:Asset3DEvent->Void):AssetLoaderToken {
private function loadData(data:Dynamic, context:AssetLoaderContext, parser:ParserBase, onAssetCallback:Asset3DEvent->Void):AssetLoaderToken
{
var token:AssetLoaderToken;

var lib:Asset3DLibraryBundle = Asset3DLibraryBundle.getInstance('Flx3DView-${__cur3DStageID}');
token = lib.loadData(data, context, null, parser);

token.addEventListener(Asset3DEvent.ASSET_COMPLETE, (event:Asset3DEvent) -> {
token.addEventListener(Asset3DEvent.ASSET_COMPLETE, (event:Asset3DEvent) ->
{
// ! Taken from Loader3D https://github.com/openfl/away3d/blob/master/away3d/loaders/Loader3D.hx#L207-L232
if (event.type == Asset3DEvent.ASSET_COMPLETE) {
var obj:ObjectContainer3D = switch (event.asset.assetType) {
if (event.type == Asset3DEvent.ASSET_COMPLETE)
{
var obj:ObjectContainer3D = switch (event.asset.assetType)
{
case Asset3DType.LIGHT: expect(event.asset, LightBase);
case Asset3DType.CONTAINER: expect(event.asset, ObjectContainer3D);
case Asset3DType.MESH: expect(event.asset, Mesh);
Expand All @@ -126,36 +141,42 @@ class Flx3DCamera extends FlxCamera {
onAssetCallback(event);
});

token.addEventListener(LoaderEvent.RESOURCE_COMPLETE, (_) -> {
token.addEventListener(LoaderEvent.RESOURCE_COMPLETE, (_) ->
{
trace("Loader Finished...");
});

_loaders.set(lib,token);
_loaders.set(lib, token);

return token;
}

override function destroy() {
override function destroy()
{
if (meshes != null)
for(mesh in meshes)
for (mesh in meshes)
mesh.dispose();

var bundle = Asset3DLibraryBundle.getInstance('Flx3DView-${__cur3DStageID}');
bundle.stopAllLoadingSessions();
@:privateAccess {
if (bundle._loadingSessions != null) {
for(load in bundle._loadingSessions) {
if (bundle._loadingSessions != null)
{
for (load in bundle._loadingSessions)
{
load.dispose();
}
}
Asset3DLibrary._instances.remove('Flx3DView-${__cur3DStageID}');
}

FlxG.stage.removeChild(view);
try {
try
{
view.dispose();
} catch(e) {

}
catch (e)
{
}

super.destroy();
Expand All @@ -164,4 +185,4 @@ class Flx3DCamera extends FlxCamera {
public function addChild(c)
view.scene.addChild(c);
#end
}
}
73 changes: 45 additions & 28 deletions source/flx3d/Flx3DView.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,27 @@ import away3d.utils.Utils.expect;
#end

// FlxView3D with helpers for easier updating
class Flx3DView extends FlxView3D {
class Flx3DView extends FlxView3D
{
#if THREE_D_SUPPORT
private static var __3DIDS:Int = 0;

var meshes:Array<Mesh> = [];
public function new(x:Float = 0, y:Float = 0, width:Int = -1, height:Int = -1) {

public function new(x:Float = 0, y:Float = 0, width:Int = -1, height:Int = -1)
{
if (!Flx3DUtil.is3DAvailable())
throw "[Flx3DView] 3D is not available on this platform. Stages in use: " + Flx3DUtil.getUsed3D() + ", Max stages allowed: " + Flx3DUtil.getTotal3D() + ".";
throw "[Flx3DView] 3D is not available on this platform. Stages in use: "
+ Flx3DUtil.getUsed3D()
+ ", Max stages allowed: "
+ Flx3DUtil.getTotal3D()
+ ".";
super(x, y, width, height);
__cur3DStageID = __3DIDS++;
}

public function addModel(assetPath:String, callback:Asset3DEvent->Void, ?texturePath:String, smoothTexture:Bool = true) {

public function addModel(assetPath:String, callback:Asset3DEvent->Void, ?texturePath:String, smoothTexture:Bool = true)
{
var model = Assets.getBytes(assetPath);
if (model == null)
throw 'Model at ${assetPath} was not found.';
Expand All @@ -52,37 +59,44 @@ class Flx3DView extends FlxView3D {
if (texturePath != null)
material = new TextureMaterial(Cast.bitmapTexture(Assets.getBitmapData(texturePath, true, false)), smoothTexture);

return loadData(model, context, switch(Path.extension(assetPath).toLowerCase()) {
return loadData(model, context, switch (Path.extension(assetPath).toLowerCase())
{
case "dae": new DAEParser();
case "md2": new MD2Parser();
case "md5": new MD5MeshParser();
case "awd": new AWDParser();
default: new OBJParser();
}, (event:Asset3DEvent) -> {
if (event.asset != null && event.asset.assetType == Asset3DType.MESH) {
var mesh:Mesh = cast event.asset;
if (material != null)
mesh.material = material;
meshes.push(mesh);
}
callback(event);
});
default: new OBJParser();
}, (event:Asset3DEvent) ->
{
if (event.asset != null && event.asset.assetType == Asset3DType.MESH)
{
var mesh:Mesh = cast event.asset;
if (material != null)
mesh.material = material;
meshes.push(mesh);
}
callback(event);
});
}

private var __cur3DStageID:Int;
private var _loaders:Map<Asset3DLibraryBundle, AssetLoaderToken> = [];

private function loadData(data:Dynamic, context:AssetLoaderContext, parser:ParserBase, onAssetCallback:Asset3DEvent->Void):AssetLoaderToken {
private function loadData(data:Dynamic, context:AssetLoaderContext, parser:ParserBase, onAssetCallback:Asset3DEvent->Void):AssetLoaderToken
{
var token:AssetLoaderToken;

var lib:Asset3DLibraryBundle;
lib = Asset3DLibraryBundle.getInstance('Flx3DView-${__cur3DStageID}');
token = lib.loadData(data, context, null, parser);

token.addEventListener(Asset3DEvent.ASSET_COMPLETE, (event:Asset3DEvent) -> {
token.addEventListener(Asset3DEvent.ASSET_COMPLETE, (event:Asset3DEvent) ->
{
// ! Taken from Loader3D https://github.com/openfl/away3d/blob/master/away3d/loaders/Loader3D.hx#L207-L232
if (event.type == Asset3DEvent.ASSET_COMPLETE) {
var obj:ObjectContainer3D = switch (event.asset.assetType) {
if (event.type == Asset3DEvent.ASSET_COMPLETE)
{
var obj:ObjectContainer3D = switch (event.asset.assetType)
{
case Asset3DType.LIGHT: expect(event.asset, LightBase);
case Asset3DType.CONTAINER: expect(event.asset, ObjectContainer3D);
case Asset3DType.MESH: expect(event.asset, Mesh);
Expand All @@ -100,26 +114,29 @@ class Flx3DView extends FlxView3D {
onAssetCallback(event);
});

token.addEventListener(LoaderEvent.RESOURCE_COMPLETE, (_) -> {
token.addEventListener(LoaderEvent.RESOURCE_COMPLETE, (_) ->
{
trace("Loader Finished...");

});

_loaders.set(lib,token);
_loaders.set(lib, token);

return token;
}

override function destroy() {
override function destroy()
{
if (meshes != null)
for(mesh in meshes)
for (mesh in meshes)
mesh.dispose();

var bundle = Asset3DLibraryBundle.getInstance('Flx3DView-${__cur3DStageID}');
bundle.stopAllLoadingSessions();
@:privateAccess {
if (bundle._loadingSessions != null) {
for(load in bundle._loadingSessions) {
if (bundle._loadingSessions != null)
{
for (load in bundle._loadingSessions)
{
load.dispose();
}
}
Expand All @@ -132,4 +149,4 @@ class Flx3DView extends FlxView3D {
public function addChild(c)
view.scene.addChild(c);
#end
}
}
Loading