Skip to content

Add "Select Strumline" Feature to Chart Editor #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kobalts19 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

Add "Select Strumline" Feature to Chart Editor #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/languages/en/Editors.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@
<str id="subtractSustainLength">Subtract sustain length</str>
<str id="selectAll">Select all</str>
<str id="selectMeasure">Select measure</str>
<str id="selectStrumline">Select Strumline</str>
<str id="noteTypesList">Note Types List</str>
<str id="editNoteTypesList">Edit Note Types List</str>
</group>
Expand Down
13 changes: 13 additions & 0 deletions source/funkin/editors/charter/Charter.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2280,6 +2280,14 @@ class Charter extends UIState {
if (note.step > Conductor.curMeasure*Conductor.getMeasureLength() && note.step < (Conductor.curMeasure+1)*Conductor.getMeasureLength()) note
];
}

function _note_selectstrumline(_) {
if (strumLines.members.length == 0) return;
var strumId = Math.floor(FlxG.mouse.getWorldPosition(charterCamera).x / 40);
if (strumId < 0 || strumId >= strumLines.totalKeyCount) return;
var hoveredStrum = strumLines.members.indexOf(strumLines.getStrumlineFromID(strumId));
if (hoveredStrum != -1) selection = [for (note in notesGroup.members) if (note.strumLineID == hoveredStrum) note];
}
#end

function changeNoteSustain(change:Float) {
Expand Down Expand Up @@ -2344,6 +2352,11 @@ class Charter extends UIState {
keybind: [CONTROL, SHIFT, A],
onSelect: _note_selectmeasure
},
{
label: translate("note.selectStrumline"),
keybind: [CONTROL, SHIFT, L],
onSelect: _note_selectstrumline
},
null
];

Expand Down