Merged
Conversation
…f the goap packages, which are compatible
Arhell
approved these changes
Jul 11, 2024
uzmasterdev
approved these changes
Aug 15, 2024
Naktibalda
reviewed
Aug 17, 2024
| "goaop/framework": "^3.0", | ||
| "php": "^8.2", | ||
| "goaop/framework": "^4.0@dev", | ||
| "goaop/parser-reflection": "^4.0@dev", |
Member
There was a problem hiding this comment.
@marcovtwout I can merge this PR, but I think that it would be better to delay release until goaop/framework 4.0.0 is released.
I added branch alias below.
Contributor
Author
There was a problem hiding this comment.
@Naktibalda Thanks! Perhaps you can update the README.md as well on master, there's still some references to the previous / PHP 7.4 version: https://github.com/Codeception/AspectMock/tree/master?tab=readme-ov-file#requirements
Contributor
Author
|
FYI: goaop/framework@dev was recently bumped to PHP 8.4, effectively raising requirements for this project from PHP 8.2 to 8.4: goaop/framework#516 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary support for PHP 8.2 by using development versions of
goaop/frameworkandgoaop/parser-reflection.If you want to test this out right now in your project, use the following in composer.json: