feat(Popover): always render outline, deprecate outline prop - #3427
Open
aresnik11 wants to merge 2 commits into
Open
feat(Popover): always render outline, deprecate outline prop#3427aresnik11 wants to merge 2 commits into
aresnik11 wants to merge 2 commits into
Conversation
Remove the boxShadow variant so the RaisedDiv and beak always render the outlined style. The outline prop is kept as a deprecated no-op for backwards compatibility, and Storybook drops the dedicated Outline story/docs and hides the prop control. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit f351673 ☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 9f926a1 ☁️ Nx Cloud last updated this comment at |
|
Collaborator
|
📬 Published Alpha Packages:
|
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://6a908d6897e6ef197a94da8b--gamut-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
Popover's outlined style (1px border, no drop shadow) is now always applied, and the beak always renders its matching border. Theoutlineprop is retained as a deprecated no-op so there are no breaking API changes — existing callers passingoutline(or omitting it) continue to compile and render.Previously
outlinetoggled between aboxShadowstyle (default) and the borderedoutlinestyle. ThatboxShadowvariant is removed.Changes
packages/gamutstyles/base.ts— folded the outline styles (border,boxShadow: 'none') intoraisedDivVariants.base, so the container is always outlined.styles/variants.ts— deleted theoutlineVariantsvariant (removes theboxShadowoption); removedbeakBorderStatesand foldedborderStylesintobeakVariants.baseso every beak is bordered unconditionally.elements.tsx— droppedoutlineVariants/beakBorderStatesfrom imports, theRaisedDiv/Beaktype unions, and the styled compositions.Popover.tsx— stopped consumingoutline, removed theoutlineprop fromRaisedDiv, and removed the conditionalhasBorderfromBeak.types.tsx— marked theoutlineprop@deprecated(kept for back-compat).packages/styleguideOutlinestory and the### Outlinedocs section (theDefault/Playgroundcanvases already show the outlined style).outlineprop from the Controls panel.Impact / visual changes
This is a visual change for any Popover that previously rendered with the default drop shadow — those now show the border instead. This includes the default
primaryvariant and internal consumers such asCoachmarkand the floating tooltip.secondary-variant popovers already rendered with a border, so they are visually unchanged.No consumer passes
outline={false}, so no downstream code relies on the removed shadow behavior.PR Checklist
Testing Instructions
above/below/center, left/right/center alignment).outlineknob, and there is no longer a dedicated Outline story.PR Links and Envs