Skip to content

Add sourcemap #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahooma merged 3 commits into from
Oct 18, 2025
Merged

Add sourcemap #345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e193f1
Add sourcemap
dannyighsu Oct 18, 2025
6fe8e7a
Remove unnecessary inclusion in package.json
dannyighsu Oct 18, 2025
c66089f
Use linked instead of external, works better with debuggers
dannyighsu Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"sideEffects": false,
"files": [
"dist",
"dist/**/*.map",
Comment thread
dannyighsu marked this conversation as resolved.
Outdated
"README.md",
"CHANGELOG.md"
],
Expand Down
2 changes: 2 additions & 0 deletions sdk/scripts/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ async function build() {
target: 'node',
format: 'esm',
minify: false,
sourcemap: 'external',
external,
naming: '[dir]/index.mjs',
loader: {
Expand All @@ -57,6 +58,7 @@ async function build() {
target: 'node',
format: 'cjs',
minify: false,
sourcemap: 'external',
Copy link
Copy Markdown
Contributor

@jahooma jahooma Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the two source maps conflict? Maybe we should just generate one, IDK

Copy link
Copy Markdown
Contributor Author

@dannyighsu dannyighsu Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need both since consumers will be either/or and not both

external,
naming: '[dir]/index.cjs',
define: {
Expand Down
1 change: 1 addition & 0 deletions sdk/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"outDir": "dist",
"strict": true,
"declaration": true,
"declarationMap": true,
"skipLibCheck": true,
"emitDeclarationOnly": true,
"esModuleInterop": true,
Expand Down
Loading