Manchester | ITP-May-26 | Abdu Hassen | Sprint 3 | Project TV Show - #80
Open
Abduhasen wants to merge 21 commits into
Open
Manchester | ITP-May-26 | Abdu Hassen | Sprint 3 | Project TV Show #80Abduhasen wants to merge 21 commits into
Abduhasen wants to merge 21 commits into
Conversation
…ml,using <template> add a function for each episodes that create a card and write all necessary information. added css style borders for texts and images
Manchester | ITP-May-26 | Abdu Hassen | sprint 1 | Project TV Show
Manchester | ITP-May-26 | Joanne O'Malley | Sprint 2 | Partner project tv show level 200
…error statement for error
Manchester | ITP-May-26 | Abdu Hassen | Sprint 2 | Level 300
Manchester | ITP-May-26 | Abdu Hassen | Sprint 2 | level 300
Manchester | ITP-May-26| Joanne O'Malley | Sprint 3 | Partner project tv show level 400
Manchester | ITP-May-26 | Abdu Hassen | Sprint 3 | Project Tv show refactoring code and creating css features
…change css color.
Manchester | ITP-May-26 | Abdu Hassen | Sprint 3 |Project TV Show Feature/level 500
Abduhasen
added
📅 Sprint 3
LonMcGregor
reviewed
Sep 2, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
- Deployed page meets all the requirements
- Good use of semantic HTML and templates
- Appropriate use of caching
Good work on this. ITP is complete now, but if you want an extra challenge, feel free to respond to my comments.
| } | ||
| return episodeCache[showId]; | ||
| } | ||
| async function setup() { |
Contributor
There was a problem hiding this comment.
Unless there's a clear reason for it, having all your functions defined inside setup might not be such a good idea. Do you think this approach is the best for your code?
| const link = card.querySelector(".episode-link"); | ||
| title.textContent = `${episode.name} - ${formatEpisodeCode(episode)}`; | ||
| image.src = episode.image?.medium || ""; | ||
| image.alt = episode.name; |
Contributor
There was a problem hiding this comment.
Is this an appropriate use of an alt tag? See what https://axesslab.com/alt-texts/ has to say
| title.textContent = `${episode.name} - ${formatEpisodeCode(episode)}`; | ||
| image.src = episode.image?.medium || ""; | ||
| image.alt = episode.name; | ||
| summary.innerHTML = episode.summary || ""; |
Contributor
There was a problem hiding this comment.
This isn't wrong, but can you think of any potential side effects of inserting the summary from the API directly into your HTML like this?
| image.alt = episode.name; | ||
| summary.innerHTML = episode.summary || ""; | ||
| if (episode.url) { | ||
| link.addEventListener("click", () => { |
Contributor
There was a problem hiding this comment.
If the purpose of this button is to open a page, is there a more semantic approach you could use than writing js to open said link?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
-created a template on html
-used the template to create a card in js
-added search bar for episode list
-added drop down for the episode list
-fetch data from API that list episodes
-added API that fetch tv show
-added search bar for tv show and drop down
-added back button from episode list
Questions