Skip to content

London | 26-SDC-MAR | Jamal Laqdiem | Sprint 5 | Prep-exercises#507

Open
jamallaqdiem wants to merge 9 commits into
CodeYourFuture:mainfrom
jamallaqdiem:prep-exercises
Open

London | 26-SDC-MAR | Jamal Laqdiem | Sprint 5 | Prep-exercises#507
jamallaqdiem wants to merge 9 commits into
CodeYourFuture:mainfrom
jamallaqdiem:prep-exercises

Conversation

@jamallaqdiem
Copy link
Copy Markdown

Self checklist

  • [ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x] My changes meet the requirements of the task
  • [ x] I have tested my changes
  • [ x] My changes follow the style guide

Changelist

Completed the prep exrcises for sprint 5.

@jamallaqdiem jamallaqdiem added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🐂 Size Medium 1-4 hours 📅 Sprint 5 Assigned during Week 5 of this module labels Apr 20, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 13, 2026
Copy link
Copy Markdown
Contributor

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the exercises seem to be missing here:

The "double" prep exercise is missing
The initial adding types exercise is missing

Also see my comment in the methods file.

Otherwise,good work on these solutions

Comment thread prep-exercises/methods.py
import datetime as dt # we import the datetime module

# this is similar to new Date() object in js, but only getting the date not hours etc.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanations of methods vs functions is missing

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing, I addressed the missing task.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good explanations

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 13, 2026
@jamallaqdiem jamallaqdiem added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 16, 2026
Copy link
Copy Markdown
Contributor

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, task complete.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 🐂 Size Medium 1-4 hours 📅 Sprint 5 Assigned during Week 5 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants