London | 25-ITP-SEP | Mariia Serhiienko| Sprint 3 | Coursework/sprint 3 practice tdd#872
Closed
Konvaly wants to merge 4 commits intoCodeYourFuture:mainfrom
Closed
London | 25-ITP-SEP | Mariia Serhiienko| Sprint 3 | Coursework/sprint 3 practice tdd#872Konvaly wants to merge 4 commits intoCodeYourFuture:mainfrom
Konvaly wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
cjyuan
reviewed
Nov 15, 2025
Contributor
cjyuan
left a comment
There was a problem hiding this comment.
This PR branch is not clean; it contains changes unrelated to "Practice TDD" exercise.
Can you revert the changes made in Sprint-2 and Sprint-3/1-implement-and-rewrite-tests folders?
Note: Your other Sprint-3 PR branch, #832, is also not clean.
If you have difficulty reverting the changes, please seek assistance from a volunteer in an in-person workshop. Alternatively, you can create new branches (make sure they are created from your main branch), transfer your Sprint-3 exercise files to the new branches, and submit new PRs (and then close the old Sprint-3 PRs).
9f50cbb to
be4e103
Compare
be4e103 to
92dc38c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
This PR covers work in the Test-First Development section of the sprint project:
Test-First Approach:
Wrote Jest tests before implementing the functions, practicing the test-driven development (TDD) process.
Jest Tests: Created and completed test files for:
Each test file follows the provided acceptance criteria and uses Jest’s syntax for clarity.
Functions were then implemented to make all tests pass.
All tests run successfully with the VS Code Test Runner or by using npm test.