Manchester| 25-ITP-Sep | Fithi Teklom| Sprint 2 | Coursework by Fithi-Teklom · Pull Request #869 · CodeYourFuture/Module-Structuring-and-Testing-Data

Fithi-Teklom · 2025-11-10T17:40:34Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

…m/Module-Structuring-and-Testing-Data into acoursework/sprint-2

WeiTsungCheng

It's mostly correct, but some errors could be reconsidered.

WeiTsungCheng · 2025-11-12T21:06:28Z

Sprint-1/1-key-exercises/3-paths.js

Great for fulfilling the requirement, but if the file path doesn't end with .txt but instead is /Users/mitch/cyf/Module-JS1/week-1/interpret/file, will const ext return a blank value?

No const ext won't return a blank value. It will incorrectly return the entire filename.

Yes, so it can be changed to return a blank value. This is because no filename extension was provided.

WeiTsungCheng · 2025-11-12T21:39:51Z

Sprint-1/2-mandatory-errors/4.js

Are the two times reversed?

ow my bad yes they are.

WeiTsungCheng · 2025-11-12T22:15:13Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

Remove .padEnd(2, "0")
Will it affect the code?

Removing .padEnd(2, "0") won't break the logic may change the output formatting in certain cases.

but may change the output formatting in certain cases.

And the important thing is that variables don't start with number.

but may change the output formatting in certain cases.

Could you give an example that might have an impact?

Ahh, removing .padEnd(2, "0") will not change the output for valid inputs, because paddedPenceNumberString is already guaranteed to be at least 3 characters long from .padStart(3, "0").

WeiTsungCheng · 2025-11-12T22:22:01Z

Sprint-2/5-stretch-extend/format-time.js

Only Test One passed the test, indicating that the function formatAs12HourClock(time) needs to be changed.

I have adjusted it.

Sorry, I didn't notice your correct version was in the commented-out area. Your new version does indeed pass the test.

Fithi-Teklom added 28 commits October 15, 2025 13:05

1-count.js updated template

458e155

updated 2-initials.js template

4302f25

updated 4.js template

4ee2dff

updated 0.js

4b28f8f

1.js updated template

c389da7

0.js updated template

f6f3ec3

2.js updated

1bcca0f

3.js updated

f4ea485

4.js updated

c77af58

updated PR

de39b05

updated js template

246a80c

updated PR template

1bbe9ed

updated 0.js template

5dfb91e

updated 1.js PR template

b3ada23

updated 2.js template

6a28411

0.js updated template

ca2b713

1.js updated pr template

468a49f

2.js updated

97592ac

1-bms.js updated

61b4f71

2-cases.js updated

302855c

3-to-pounds.js updated

78694da

time-format.js updated

95da651

5.format-time.js updated

b00b826

Delete Sprint-1/1-key-exercises/2-initials.js

c6a1e91

Delete Sprint-1/1-key-exercises/1-count.js

fac10ba

0.js updated

2302edc

Merge branch 'acoursework/sprint-2' of https://github.com/Fithi-Teklo…

addadec

…m/Module-Structuring-and-Testing-Data into acoursework/sprint-2

1.js updated

5dc0b96

Fithi-Teklom added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 10, 2025

WeiTsungCheng removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 12, 2025

WeiTsungCheng added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Nov 12, 2025

WeiTsungCheng reviewed Nov 12, 2025

View reviewed changes

WeiTsungCheng added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 12, 2025

removed padEnd(2, 0) because it is doing nothing

86131fe

Fithi-Teklom added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 16, 2025

Fithi-Teklom mentioned this pull request Nov 17, 2025

ITP- SEP-2025 | Structuring and testing data | Fithi-Teklom #886

Closed

WeiTsungCheng added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 17, 2025

Fithi-Teklom mentioned this pull request Nov 19, 2025

ITP-25-SEP | Structuring and testing data | Fithi-Teklom Fithi-Teklom/Module-Structuring-and-Testing-Data#1

Open

illicitonion closed this Jan 7, 2026

Uh oh!

Conversation

Fithi-Teklom commented Nov 10, 2025

Uh oh!

WeiTsungCheng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants