Manchester| 25-ITP-September | Fithi Teklom| Sprint 3 | 2-practice-tdd#863
Manchester| 25-ITP-September | Fithi Teklom| Sprint 3 | 2-practice-tdd#863Fithi-Teklom wants to merge 18 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
cjyuan
left a comment
There was a problem hiding this comment.
The test in get-oridinal-number.test.js could use some improvement.
All other changes look good.
|
I have cleaned my branch. |
|
Branch is clean. Well done! You placed Jest test script for |
There was a problem hiding this comment.
Have you tried running this test script to make sure it can run properly?
There was a problem hiding this comment.
Now I have made sure that the tests have all passed.
|
Looks good. |
Self checklist