Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 2 | Coursework#705
Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 2 | Coursework#705shreefAhmedM wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
4 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
shreefAhmedM
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Why not also practice committing files one by one? Making small commits has the following advantages:
- Clarity: Each commit tells a clear story (one feature, one fix, one change).
- Debugging: Easy to find and undo the commit that caused a bug.
- Collaboration: Teammates can review and understand changes faster.
- History: Project log becomes a readable timeline, not a messy dump.
- Safety: Progress is saved in safe, logical steps—less risk of losing work.
If you would like to practice committing files one by one in VSCode, you can select which file to stage and then commit only the staged file.
See: this video (at around the 12:50 mark, it shows how to stage a single file).
If you prefer using the git command (which most professionals do), the W3School Git Tutorial
is a good place to start.
There was a problem hiding this comment.
I renamed by mistake, i have updated to 1-bmi.js
| // =============> write your answer here. one time | ||
|
|
||
| // Call formatTimeDisplay with an input of 61, now answer the following: | ||
|
|
||
| // b) What is the value assigned to num when pad is called for the first time? | ||
| // =============> write your answer here | ||
| // =============> write your answer here .is 60 | ||
|
|
||
| // c) What is the return value of pad is called for the first time? | ||
| // =============> write your answer here | ||
| // =============> write your answer here is 0 |
There was a problem hiding this comment.
These answers are not quite correct, and you missed questions (d) and (e).
In addition, if a value is a string, it is a common practice to enclose the value with a pair of single/double quote characters to emphasize that it is a string.
There was a problem hiding this comment.
Did you forget to commit your change? I don't notice any new change in this file.
| } | ||
| return `${time} am`; | ||
|
|
||
| const formattedHour = HoursModefied < 10 ? "0" + HoursModefied : HoursModefied.toString(); |
There was a problem hiding this comment.
We could also use .padStart().
| function toUpperSnakeCase(str){ | ||
| let SnakeCaseStr = str.replace(/ /g, "_") | ||
| return SnakeCaseStr.toUpperCase() | ||
| } |
There was a problem hiding this comment.
-
Indentation is a bit off.
-
It is a common practice to begin variable names with a lowercase letter. Names that start with an uppercase letter are typically reserved for user-defined data types or class names.
cjyuan
added
Reviewed
shreefAhmedM
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
It seems the file Sprint-2/4-mandatory-interpret/time-format.js has not been updated.
cjyuan
removed
the
Needs Review
shreefAhmedM
added
the
Needs Review
Because my changes were in lines that have common, Sorry, can you look again, i committed the changes? |
|
Everything looks good now. Good job. |
cjyuan
added
Complete
3 participants
Self checklist
Her is JavaScript challenges tasks covering exercises, error fixing, code interpretation, and a stretch exploration activity.